LFP Viewer support for low sampling rates#704
Conversation
anjaldoshi
left a comment
There was a problem hiding this comment.
Hi @roberttoth02,
Thanks a lot for digging into this and fixing the low-sample-rate issues in the LFP Viewer.
This PR looks great overall, and thanks for targeting the development branch. That helps a lot since we already have a few other LFP Viewer changes there. The timing is great too, since we’re hoping to ship v1.1.0 this week and we’d love to get this in.
I went through the code and the approach makes a lot of sense. We just haven’t had much opportunity to exercise the viewer with very low sample-rate data before, especially below 100 Hz.
I also tested this locally with the LSL Inlet plugin using pylsl to stream sine-wave data at low sampling rates. Just like you described in the issue, the current development behavior drifts quite a bit once the samples-per-pixel ratio drops below 1, and at 1 Hz it basically fails. With your changes, the drift looks fixed and the traces render much more naturally with the interpolation.
The new tests are a really helpful addition too.
Overall, this is a solid fix, and I’m glad we can get it into v1.1.0.
Resolves #703