chore(deps): update docker.io/library/postgres docker tag to v18#233
Conversation
Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR. I'm waiting for a openshift-hyperfleet member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe default PostgreSQL container image in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Supply chain surface — verify before merge.
🚥 Pre-merge checks | ✅ 10 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/values.yaml`:
- Line 318: The PostgreSQL image version jump from 14 to 18.4 in the values.yaml
file will break existing deployments due to data directory incompatibility
across major versions. Add a new configuration parameter (such as
postgresql.version or postgresql.majorVersion) to the values.yaml file to gate
this change, include a deprecation warning or migration flag in the default
values, and add comprehensive migration instructions in the NOTES.txt file that
document the required pg_upgrade or dump/restore steps for users with existing
PostgreSQL installations. Ensure the values.yaml comments clearly warn about the
breaking change and provide links to upgrade documentation.
- Line 318: Bump the Chart.yaml version to indicate a breaking change from the
PostgreSQL upgrade (PostgreSQL 14 to 18 is a major version change). Update all
references to postgres:14.2 in README.md (lines 142, 146, 148) to reflect the
new postgres:18.4 image. Add migration guidance to NOTES.txt that clearly warns
users about the breaking PostgreSQL upgrade and provides steps for safe data
migration during the upgrade process.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 36f839fb-41ca-430e-994e-875a5a825c43
📒 Files selected for processing (1)
charts/values.yaml
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
openshift-hyperfleet/architecture(manual)openshift-hyperfleet/hyperfleet-api(manual)openshift-hyperfleet/hyperfleet-sentinel(manual)openshift-hyperfleet/hyperfleet-adapter(manual)openshift-hyperfleet/hyperfleet-broker(manual)
| enabled: true | ||
| # -- PostgreSQL container image | ||
| image: docker.io/library/postgres:14.2 | ||
| image: docker.io/library/postgres:18.4 |
There was a problem hiding this comment.
PostgreSQL 14→18 upgrade requires data migration; existing deployments will fail.
This jumps four major versions. PostgreSQL data directories are NOT forward-compatible across major versions. Existing StatefulSets that restart with this image will crash with binary incompatibility errors (CWE-665: Improper Initialization). Production impact: data inaccessible, service down.
Required before merge:
- Add migration instructions to NOTES.txt or values.yaml comments
- Consider gating this behind a new flag (e.g.,
postgresql.version) with validation - Document pg_upgrade or dump/restore steps for existing installations
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@charts/values.yaml` at line 318, The PostgreSQL image version jump from 14 to
18.4 in the values.yaml file will break existing deployments due to data
directory incompatibility across major versions. Add a new configuration
parameter (such as postgresql.version or postgresql.majorVersion) to the
values.yaml file to gate this change, include a deprecation warning or migration
flag in the default values, and add comprehensive migration instructions in the
NOTES.txt file that document the required pg_upgrade or dump/restore steps for
users with existing PostgreSQL installations. Ensure the values.yaml comments
clearly warn about the breaking change and provide links to upgrade
documentation.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify chart version was bumped and docs are consistent
echo "=== Chart.yaml version ==="
cat charts/Chart.yaml | grep -E '^version:'
echo -e "\n=== README.md postgres image references ==="
rg -n 'postgres:14\.2|postgres:18\.4' charts/README.md
echo -e "\n=== NOTES.txt upgrade warnings ==="
if [ -f charts/templates/NOTES.txt ]; then
rg -n -i 'upgrade|migration|postgres.*14|postgres.*18' charts/templates/NOTES.txt || echo "No upgrade warnings found"
else
echo "NOTES.txt does not exist"
fi
echo -e "\n=== values.yaml comment warnings ==="
rg -n -B2 -A2 'postgres:18\.4' charts/values.yamlRepository: openshift-hyperfleet/hyperfleet-api
Length of output: 1558
🏁 Script executed:
#!/bin/bash
echo "=== Git diff for Chart.yaml version ==="
git diff HEAD~1 charts/Chart.yaml | grep -E '^\+version:|^-version:' || echo "No version change detected in diff"
echo -e "\n=== Full NOTES.txt content ==="
if [ -f charts/templates/NOTES.txt ]; then
cat -n charts/templates/NOTES.txt
else
echo "NOTES.txt not found"
fi
echo -e "\n=== Full values.yaml postgresql section ==="
sed -n '310,330p' charts/values.yamlRepository: openshift-hyperfleet/hyperfleet-api
Length of output: 2980
Chart.yaml version not bumped despite breaking PostgreSQL upgrade path; README.md stale; missing migration guidance in NOTES.txt.
PostgreSQL 14 → 18 is a breaking change requiring data migration. This PR introduces that incompatibility without:
- Incrementing Chart.yaml version (currently 1.1.0, no change detected)
- Updating README.md (lines 142, 146, 148 still reference
postgres:14.2) - Adding migration warnings to NOTES.txt (no upgrade/migration guidance present)
Users upgrading will face silent database failures without a documented migration path.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@charts/values.yaml` at line 318, Bump the Chart.yaml version to indicate a
breaking change from the PostgreSQL upgrade (PostgreSQL 14 to 18 is a major
version change). Update all references to postgres:14.2 in README.md (lines 142,
146, 148) to reflect the new postgres:18.4 image. Add migration guidance to
NOTES.txt that clearly warns users about the breaking PostgreSQL upgrade and
provides steps for safe data migration during the upgrade process.
|
Closing — this bumps PostgreSQL from 14.2 to 18.4, which is a 4 major version jump. PostgreSQL data directories are not forward-compatible across major versions — existing StatefulSets would crash on restart with binary incompatibility errors. The safe patch-level update (14.2 → 14.23, same major version) is included in #237 (HYPERFLEET-1264) instead. |
1 participant
This PR contains the following updates:
14.2→18.4Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Configuration
📅 Schedule: Branch creation - "on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.