OCPBUGS-94014: Rebase v3.6.12 for 5.0/4.23#390
Open
dusk125 wants to merge 12 commits into
Open
Conversation
Signed-off-by: shenmu.wy <shenmu.wy@antfin.com>
….25.10 [release-3.6] Bump Go to 1.25.10
Signed-off-by: shenmu.wy <shenmu.wy@antfin.com>
…mberupdate-learner [release-3.6] bugfix: MemberUpdate implicitly and unexpectedly promotes a learner
… of panic when given non-existent paths Signed-off-by: shenmu.wy <shenmu.wy@antfin.com>
…nvalid-datadir [release-3.6] etcdutl: validate data file path instead of panic
- replace user.Current().Name == "root" with os.Getuid() == 0. - drop os/user import and user.Current() error path. - backport of etcd-io#21788 - address: etcd-io#21787 Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com>
…elease-3.6 [release-3.6] client/pkg/fileutil: use os.Getuid() to skip TestIsDirWriteable as root
Signed-off-by: kunal.behbudzade <kunal.behbudzade@btsgrp.com> Signed-off-by: Ian Chechin <ian00chechin@gmail.com>
[release-3.6] server: allow non-admin maintenance status
Signed-off-by: Ivan Valdes <iv@a.ki>
WalkthroughBumps etcd to v3.6.12 and Go toolchain to 1.25.10 across all modules. Fixes ChangesGo toolchain and v3.6.12 module version bump
Functional fixes and new features
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 11❌ Failed checks (1 warning, 10 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@etcdutl/etcdutl/common.go`:
- Around line 41-43: validateFilePath currently only checks os.Stat, so it still
accepts directories and lets invalid inputs reach later backend code. Update
validateFilePath in common.go to verify the path is a regular file (or
explicitly reject directories) after Stat, and return an error for directory
inputs so callers like hashkv and snapshot status get the expected early
validation.
In `@server/etcdserver/api/membership/cluster.go`:
- Around line 628-635: The info log in the cluster membership path is exposing
raw internal peer URLs via raftAttr.PeerURLs, which can leak topology. Update
the logging in the member update flow around the existing c.lg.Info call to
remove the full URL list and instead log a safer identifier such as the member
ID and/or the count of peer URLs. Keep the rest of the diagnostic context intact
while ensuring no internal hostnames are emitted.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b9478df3-5295-4859-a5e8-d6504f93016a
📒 Files selected for processing (25)
.go-versionapi/go.modapi/version/version.goclient/pkg/fileutil/fileutil_test.goclient/pkg/go.modclient/v3/go.modetcdctl/go.modetcdutl/etcdutl/common.goetcdutl/etcdutl/defrag_command.goetcdutl/etcdutl/hashkv_command.goetcdutl/etcdutl/migrate_command.goetcdutl/etcdutl/snapshot_command.goetcdutl/go.modgo.modpkg/go.modserver/etcdserver/api/membership/cluster.goserver/etcdserver/api/membership/cluster_test.goserver/etcdserver/api/v3rpc/maintenance.goserver/go.modtests/common/maintenance_auth_test.gotests/go.modtests/integration/clientv3/cluster_test.gotools/mod/go.modtools/rw-heatmaps/go.modtools/testgrid-analysis/go.mod
dusk125
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@dusk125: This pull request references Jira Issue OCPBUGS-94014, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Author
|
/test all |
|
@dusk125: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Chores