Clean up skipped date picker tests#3258
Merged
Merged
Conversation
- delete stale describe.skip blocks in DateTimeRangePicker.spec (they tested a removed Load/Reset custom-mode UI); keep the working preset-selection test - convert client.spec.tsx to a React-free client.spec.ts that calls the API methods directly; processServerError is already covered by errors.spec and the RQ wrappers by e2e - stub ResizeObserver in unit setup so Headless UI works without the resize-observer-polyfill dep - remove resize-observer-polyfill (only consumer was the deleted picker test) and identity-obj-proxy (dead, referenced nowhere)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some very old skipped tests that wouldn't even work anymore (I think we redid the date picker). Deleting those let me also delete a couple of otherwise unused dev deps. I also had the robot add e2e tests for the date picker with a custom range, which was untested.