🎨 Palette: Enter-to-send in chat drawer#29
Conversation
Added an `onKeyDown` handler to the `Textarea` in `SessionDrawer` to support Enter-to-send functionality, improving keyboard usability. Updated the placeholder text to make this discoverable, and added an `aria-label` attribute for better screen reader accessibility. Recorded the learning in the `.Jules/palette.md` journal. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e9e105c23
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (e.key === "Enter" && !e.shiftKey) { | ||
| e.preventDefault(); | ||
| if (!sending && message.trim()) { |
There was a problem hiding this comment.
For users entering Japanese, Chinese, or Korean with an IME, Enter is used to confirm the current conversion and the keyboard event is emitted with isComposing. This handler intercepts it, prevents the conversion from being committed, and sends the partially composed follow-up instead. Guard the send path with !e.nativeEvent.isComposing (and allow the native event through while composing).
Useful? React with 👍 / 👎.
1 participant
💡 What: Implemented Enter-to-send functionality in the session drawer chat interface.
🎯 Why: Users expect chat-like inputs to submit via the Enter key. Without it, they are forced to break keyboard flow and use the mouse to click "Send follow-up".
📸 Before/After: Placeholder now indicates "(Press Enter to send)".
♿ Accessibility: Added an explicit
aria-labelto the textarea since it lacked an explicit<label>and previously relied solely on the placeholder attribute for screen reader context.Adheres to Palette's constraints: code changes are minimal (< 50 lines), use existing styling, and significantly improve standard UI interaction patterns.
PR created automatically by Jules for task 3197760147388994004 started by @parvezk