feat: stream cross-shard ORDER BY results with k-way merge#1114
Open
murex971 wants to merge 3 commits into
Open
feat: stream cross-shard ORDER BY results with k-way merge#1114murex971 wants to merge 3 commits into
murex971 wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
levkk
reviewed
Jun 29, 2026
|
|
||
| read = true; | ||
| if let Some(message) = state.forward(message)? { | ||
| if let Some(message) = state.forward_from(position, message)? { |
Collaborator
There was a problem hiding this comment.
nit: rename position to shard
levkk
reviewed
Jun 29, 2026
| use super::Aggregates; | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| struct OrderByMergeState { |
Collaborator
There was a problem hiding this comment.
nit: would be good to move that to its own file.
Collaborator
|
Looks good. We would need quite a few integration tests for this one though before it's in a mergeable state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ORDER BYqueries with a streaming k-way merge path.Tests
Related issues/comments
closes #207