ext/session: prevent creation of fixed sid in php_session_rfc1867#22113
Open
jorgsowa wants to merge 2 commits into
Open
ext/session: prevent creation of fixed sid in php_session_rfc1867#22113jorgsowa wants to merge 2 commits into
jorgsowa wants to merge 2 commits into
Conversation
Girgias
reviewed
May 24, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
This seems sensible, but not super familiar with RFC 1867, maybe @iluuu1994 or @bukka have some comments?
jorgsowa
force-pushed
the
fix/session-upload-progress-use-only-cookies
branch
from
164e5fb to
abd2d93
Compare
Contributor
Author
|
I have added missing entry in NEWS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RFC1867 multipart callback captures the session ID from form data to identify which session to write the upload progress to. When
session.use_only_cookies=1this capture was not guarded, allowing the session ID to be accepted from a form field despite the setting's documented contract of "only accept session ID from cookies."php_session_rfc1867_early_find_sid()already guards $_GET lookup behinduse_only_cookies, but the form field capture inMULTIPART_EVENT_FORMDATAhad no such guard.This commit adds the missing check so that when
use_only_cookies=1and no cookie is present, the form-supplied session ID is ignored and the upload progress is written to a randomly generated session instead.I don't know if this is a security fix, so I point to the 8.4 branch.