Skip to content

zend_string: Add zend_string_equals_cstr_ci()#22296

Merged
TimWolla merged 1 commit into
php:masterfrom
TimWolla:zend_string_equals_cstr_ci
Jun 14, 2026
Merged

zend_string: Add zend_string_equals_cstr_ci()#22296
TimWolla merged 1 commit into
php:masterfrom
TimWolla:zend_string_equals_cstr_ci

Conversation

@TimWolla

Copy link
Copy Markdown
Member

This function was missing for consistency with the other functions which all have a cstr variant. Adding this function also made it easy to convert some more copy-and-pasted logic.

@TimWolla TimWolla requested a review from iluuu1994 June 13, 2026 14:46
@TimWolla TimWolla requested a review from dstogov as a code owner June 13, 2026 14:46
@TimWolla TimWolla force-pushed the zend_string_equals_cstr_ci branch 2 times, most recently from 86cfde3 to 0e6621a Compare June 13, 2026 15:21
This function was missing for consistency with the other functions which all
have a `cstr` variant. Adding this function also made it easy to convert some
more copy-and-pasted logic.
@TimWolla TimWolla force-pushed the zend_string_equals_cstr_ci branch from 0e6621a to 3c98b23 Compare June 13, 2026 15:35

@Girgias Girgias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I've been looking for this function a few times.

@TimWolla TimWolla merged commit 3c6b25c into php:master Jun 14, 2026
18 checks passed
@TimWolla TimWolla deleted the zend_string_equals_cstr_ci branch June 14, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants