feat(read-tools): github_pr_diff — a PR's full unified diff (v0.1.3)#20
Conversation
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #20 | feat(read-tools): github_pr_diff — a PR's full unified diff (v0.1.3)
VERDICT: PASS (with observations)
CI Status
- No CI checks found for this PR — unverified. Treated as a Gap, not a blocker.
Diff Review
- Adds
github_pr_diff(number, repo?, max_chars=12000)toread_tools.py— wrapsgh pr diffwith the identical contract pattern asgithub_get_commit_diff(resolve_repo → bad_repo → run_gh → check_gh_error → strip → truncate). - 5 tests in
tests/test_read_tools.py: happy path + arg shape, truncation, empty diff, bad-repo short-circuit (assertsrun_ghnot called), gh error surfacing. - Version bumped 0.1.2 → 0.1.3 lockstep in
protoagent.plugin.yaml+pyproject.toml.
Observations
- LOW:
clawpatch_reviewtimed out — structural review skipped. Diff-based review found no issues; the tool is a narrow, well-factored addition following an established pattern. - GAP: CI not accessible — no checks visible for this PR. Not a code defect.
— Quinn, QA Engineer
|
Submitted COMMENT review on #20. |
The adversarial review workflow's diff source (delivery-loop plan M1/F1.1, protoAgent ADR 0077): review-finder subagents read the change itself, not just the PR metadata github_get_pr returns. `gh pr diff` via run_gh, default-repo fallback, max_chars truncation, readable Error degradation — same contract as the other read tools. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mabry1985
force-pushed
the
feat/github-pr-diff
branch
from
8e383c1 to
75f3192
Compare
|
✅ CI went terminal-green with no blockers on the prior review — promoting it to APPROVED per the approve-on-green policy (#748). |
There was a problem hiding this comment.
QA Audit — PR #20 | feat(read-tools): github_pr_diff — a PR's full unified diff (v0.1.3)
VERDICT: PASS (pending CI; auto-promotes on terminal-green)
CI Status
- test: in_progress
Once test completes terminal-green, the approve-on-green policy automatically promotes this review to APPROVED and the PR merges. No further review needed.
Incremental Diff (8e383c1 → 75f3192)
- Version bump 0.1.5 → 0.1.6 in
protoagent.plugin.yaml+pyproject.toml— the only change since prior review. Thegithub_pr_difftool and 5 tests are unchanged from what was PASSed at8e383c1. - Clawpatch structural review: no findings in diff-touched feature slices.
Observations
- LOW: clawpatch report had 2 high-level notes but no structured findings surfaced — diff-based review remains clean.
- GAP: CI still running (
test: in_progress) — approve-on-green handles promotion.
— Quinn, QA Engineer
|
Submitted COMMENT review on |
1 participant
F1.1 of the codified-delivery-loop plan (protoAgent
docs/plans/codified-delivery-loop.md, M1): the adversarial review workflow's finder subagents need to read the change itself, not just the metadatagithub_get_prreturns.github_pr_diff(number, repo?, max_chars=12000)—gh pr diffviarun_ghresolve_repo),bad_repovalidation before any gh call,check_gh_errordegradation to a readableError:string, truncation note atmax_charsrun_gh(happy path + args, truncation, empty diff, bad repo short-circuit, gh error)92 passed. Version 0.1.3 lockstep (manifest + pyproject).
Consumed next by protoAgent's
code-reviewworkflow recipe (review-finder allowlist) and later the board's blocking review gate (M5).🤖 Generated with Claude Code