Feat: Add optional clock to TV player#2941
Conversation
JelleSThijs
commented
Jun 22, 2026
JelleSThijs
commented
- Add a new TV layout clock setting to the player option menu.
- Add a new Text clock to the tv player layout. Take 12AM/PM and 24 hour clocks into account.
fire-light42
left a comment
fire-light42
left a comment
There was a problem hiding this comment.
A very elegant solution with TextClock! Good code and clean implementation.
There are only some minor nitpicks which are difficult (if not impossible) for a first-time contributor to know about.
… the fully shared ui logic
- Transfer tv_layout_clock_key from strings.xml to donottranslate-strings.xml. - Rename the string value to adhere to the already existing keys.
- Use playerBinding?.playerVideoClock instead of using getViewById. - Use isVisible instead of an if statement for the visibility logic
fire-light42
left a comment
fire-light42
left a comment
There was a problem hiding this comment.
Everything looks good!
@KingLucius what do you think?
Code is very clean and elegant as you said 👍 but I have a concern on UI TextClock position, I was thinking about put it in the middle, I didn't try it though Also, clock is needed on Home page also, was thinking on adding it to top of navbar (that's what I was working on) to avoid crowded right area above the provider selector buttons. |
|
I will add the clock to the homepage, but i don't know how you would want to place the clock in the top center in the player, since that might overlap with the download header. |
3 participants
