Skip to content

[fixes] Couple ClassPropertyAssignToConstructorPromotionRector, RemoveAlwaysTrueIfConditionRector and RemoveUnusedVariableAssignRector fixes#8055

Merged
TomasVotruba merged 2 commits into
mainfrom
tv-fix-maut-3
Jun 19, 2026
Merged

[fixes] Couple ClassPropertyAssignToConstructorPromotionRector, RemoveAlwaysTrueIfConditionRector and RemoveUnusedVariableAssignRector fixes#8055
TomasVotruba merged 2 commits into
mainfrom
tv-fix-maut-3

Conversation

@TomasVotruba

@TomasVotruba TomasVotruba commented Jun 19, 2026

Copy link
Copy Markdown
Member
  • [dead-code] Fix RemoveUnusedVariableAssignRector, allow for SplFileInfo as cleanup on purpose for gc
  • [dead-code] Fix RemoveAlwaysTrueIfConditionRector with dynamic variable
  • [php 8.0] Skip merged property in PromotedPropertyCandidateResolver
  • [php 8.0] Add fix for ClassPropertyAssignToConstructorPromotionRector if it contains @var of more specific type

As spotted in:

@TomasVotruba TomasVotruba changed the title tv fix maut 3 [php 8.0] Couple ClassPropertyAssignToConstructorPromotionRector and RemoveUnusedVariableAssignRector fixes Jun 19, 2026
@TomasVotruba TomasVotruba changed the title [php 8.0] Couple ClassPropertyAssignToConstructorPromotionRector and RemoveUnusedVariableAssignRector fixes [fixes] Couple ClassPropertyAssignToConstructorPromotionRector and RemoveUnusedVariableAssignRector fixes Jun 19, 2026
@TomasVotruba TomasVotruba changed the title [fixes] Couple ClassPropertyAssignToConstructorPromotionRector and RemoveUnusedVariableAssignRector fixes [fixes] Couple ClassPropertyAssignToConstructorPromotionRector, RemoveAlwaysTrueIfConditionRector and RemoveUnusedVariableAssignRector fixes Jun 19, 2026
@TomasVotruba TomasVotruba force-pushed the tv-fix-maut-3 branch 2 times, most recently from 50ddcae to 78cf63d Compare June 19, 2026 21:54
@TomasVotruba TomasVotruba merged commit 40dfda3 into main Jun 19, 2026
65 checks passed
@TomasVotruba TomasVotruba deleted the tv-fix-maut-3 branch June 19, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant