[reporting] Add reportUnusedSkips() to report skips that never matched#8058
Merged
Conversation
Adds a ->reportUnusedSkips() config option, similar to PHPStan's reportUnusedIgnores. Tracks which ->withSkip() elements actually matched during a run via a shared UsedSkipCollector, then warns about path and rule-with-path skips that never matched and can be removed. Used skips are aggregated across parallel workers through the process bridge and carried on ProcessResult. Skip-everywhere rule skips are forgotten from the container at boot, so they are not trackable at runtime and are excluded from the report.
TomasVotruba
changed the title
Member
Author
|
Let's test this in a wild 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of long
->skip([])method inrector.phpconfig, users sometime need a quick way to verify what was fixed. So do we to check if bug is still there or not.Similar to PHPStan feature, that reports unused skips: https://phpstan.org/user-guide/ignoring-errors#reporting-unused-ignores