[codex] Prepare registry-stack v0.8.4 beta-10#192
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 717aaeb0d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| release: beta-10 | ||
| version: 0.8.4 | ||
| source_repo: registrystack/registry-stack | ||
| source_ref: ebe613a7e712341884d10bf4e5c64e48b2591bad |
There was a problem hiding this comment.
The SHA here is this commit's parent (ebe613...), whose Cargo.toml still declares 0.8.3, while this manifest advertises 0.8.4 artifacts and release-candidate status. Any release audit or consumer resolving beta-10 from source_ref will land on the previous-version tree and miss the release prep files, so pin this to the actual v0.8.4 candidate/merge commit or keep it draft/HEAD until finalization.
Useful? React with 👍 / 👎.
| products: | ||
| registry-stack: | ||
| version: v0.8.4 | ||
| ref: ebe613a7e712341884d10bf4e5c64e48b2591bad |
There was a problem hiding this comment.
This archived docset is labeled v0.8.4, but the refs point at the pre-release parent (ebe613...), which still has the workspace and docs metadata at 0.8.3; the same SHA is repeated for the other RegistryStack products below. Archive generation uses these refs for product docs, so /v/0.8.4/ will pull stale product content/OpenAPI sources unless these refs are updated to the actual v0.8.4 release commit.
Useful? React with 👍 / 👎.
| trap cleanup EXIT | ||
|
|
||
| has_opencrvs_dci_credentials() { | ||
| [[ -f "${demo_dir}/.env.local" ]] && return 0 |
There was a problem hiding this comment.
Treating any .env.local as credentials makes the new auto mode sticky after a one-off smoke run with credentials exported: smoke-opencrvs-dci.sh writes .env.local with derived tokens, hashes, port, and the discovered UIN, but it does not persist OPENCRVS_DCI_CLIENT_ID or OPENCRVS_DCI_CLIENT_SECRET. A later release-check.sh run without those exports will enter the smoke instead of auto-skipping and then fail on the missing credential variables, so this helper should verify those keys are present in .env.local rather than checking only file existence.
Useful? React with 👍 / 👎.
1 participant
Summary
registry-stackv0.8.4/registry-stack-beta-10as the next beta release candidaterelease/notes/v0.8.4.mdrelease/manifests/registry-stack-beta-10.yamland marks beta-8/beta-9 release candidates as releasedVerification
release/scripts/registry-release validate release/manifests/registry-stack-beta-10.yamlrelease/scripts/registry-release validate release/manifests/registry-stack-beta-8.yamlrelease/scripts/registry-release validate release/manifests/registry-stack-beta-9.yamlrelease/scripts/registry-release audit release/manifests/import-map-2026-06-24.yamlrelease/scripts/registry-release classify-warning hosted-publication-heldcargo metadata --format-version 1cargo metadata --locked --format-version 1cargo test --locked -p registry-platform-authcommon -p registry-manifest-core -p registry-notary-server -p registry-relay -p registryctlbash -n lab/scripts/release-check.shbash -n lab/scripts/smoke-opencrvs-dci.shpython3 -m py_compile lab/scripts/smoke-notary-client.pyenv -u OPENCRVS_DCI_BASE_URL -u OPENCRVS_DCI_CLIENT_ID -u OPENCRVS_DCI_CLIENT_SECRET -u OPENCRVS_DCI_NOTARY_PORT -u OPENCRVS_DEMO_SUBJECT_UIN lab/scripts/smoke-opencrvs-dci.sh(expected missing-credential failure path)REGISTRY_LAB_RELEASE_SOURCE_MODE=monorepo lab/scripts/release-check.shpython3 -m unittest release/scripts/test_registry_release.pypython3 -m unittest lab/scripts/test_check_release_source_model.pyuv run --with pyarrow --with openpyxl --with pyyaml python -m unittest scripts/test_generate_fixtures.pyfromlab/git diff --checkcargo fmt --checkcargo check --locked --workspace --all-targetsnpm --prefix docs/site installnpm --prefix docs/site run generatenpm --prefix docs/site run checkNotes
The legacy split-repo
just ci-preflighthelpers undercrates/registry-relayandproducts/notarystill fail after the monorepo migration because they copy only the subdirectory and then Cargo cannot inherit root workspace package metadata. I did not change those stale helpers in this release-prep branch; the active monorepo gates above passed.After this PR merges, the finalize step must update the beta-10 manifest
source_refand thev0.8.4archived docs refs from the prepare-candidate SHA to the actual merge SHA before taggingv0.8.4.