feat!: Node.js 26 support#1990
Open
dianager wants to merge 13 commits into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
b3dd1d3 to
3f202ce
Compare
3f202ce to
56f6f8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
make prepushIssues
Closes:
Changes
Upgrades restify to run on Node.js 22, 24, and 26. Resolves all deprecated and removed
Node.js APIs, drops a broken production dependency, and fixes two production security
vulnerabilities.
Breaking Changes
options.spdyis removed. Useoptions.http2instead.qs6.15.2 changes array parsing. Bracket-notation arrays with more than 20items are returned as objects with numeric string keys (enforced
arrayLimit).This is a consequence of CVE-2022-24999 fix, not an accidental regression.
Security
qsupgraded^6.7.0→^6.15.2spdyremovedWhy
spdywas removed rather than upgradedspdyfails to start on Node.js 22+ regardless of version because two of itstransitive dependencies (
http-deceiver,handle-thing) callprocess.binding(),a private C++ internal API removed in Node.js 22. This causes a hard crash at module
load time. No patched release exists. Combined with open CVEs and an abandoned
maintainer, removal was the only option. Use
options.http2as the replacement.Deprecated API Fixes
All of the following APIs were removed in Node.js 24 or 26 and would throw at runtime.
url.parse()/url.resolve()lib/request.js,lib/response.jsURL, newutils.parseRequestUrl()/utils.formatUrl()request.connectionlib/request.js,lib/plugins/audit.js,lib/plugins/throttle.jsrequest.socketnew Buffer()lib/formatters/binary.js,lib/plugins/authorization.js,lib/plugins/bodyReader.jsBuffer.from()/Buffer.alloc()request.abort()test/plugins/userAgent.test.jsrequest.destroy()module.parentbenchmark/benchmarks/*.js,test/lib/helper.jsrequire.main === moduleOther
engines.nodeset to>=22.0.0(Node 22 is oldest version still in LTS)next()calls.eslintrc.js: fixed dot-notation rule violations that broke the lint job