fix: enforce submit frequency in RocketNetworkPrices.submitPrices#344
Open
Sertug17 wants to merge 1 commit into
Open
fix: enforce submit frequency in RocketNetworkPrices.submitPrices#344Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
RocketNetworkPrices has a configured submit frequency (default 1 day) via RocketDAOProtocolSettingsNetwork.getSubmitPricesFrequency(), but submitPrices never checked it. RocketNetworkBalances does check its equivalent frequency setting using the same pattern. Added a timestampKey storage slot, getPricesTimestamp() getter, and frequency check in both submitPrices and executeUpdatePrices that mirrors the balances contract's approach with the 95% tolerance window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the frequency gate that was missing from the price submission path. The frequency setting exists in
RocketDAOProtocolSettingsNetwork(network.submit.prices.frequency) and is used by the settings interface, butsubmitPricesandexecuteUpdatePricesnever checked it unlikeRocketNetworkBalanceswhich does enforce its equivalent setting.Closes #342