fix: add overflow check for unchecked exponentiation in getNodeFeeByDemand#345
Open
Sertug17 wants to merge 1 commit into
Open
fix: add overflow check for unchecked exponentiation in getNodeFeeByDemand#345Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
…emand The function was using ** 3 on a value that's read from contract storage. SafeMath doesn't cover exponentiation, so in Solidity 0.7.6 the ** operator can silently wrap on overflow. Added a manual overflow check after the cube multiplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
** 3operator in Solidity 0.7.6 doesn't have built-in overflow protection, and SafeMath doesn't cover exponentiation either. Split the cube into three multiplications with a check that reverts on overflow.Closes #343