Add read-only pool and pool share commands to the OSC client#6
Open
misamoylov wants to merge 1 commit into
Open
Add read-only pool and pool share commands to the OSC client#6misamoylov wants to merge 1 commit into
misamoylov wants to merge 1 commit into
Conversation
Pool lifecycle is owned by `designate-manage pool`, so upstream carries no
pool commands in the client and the pool create/update/delete API methods
are deprecated. Restore only the read-only surface that is safe to use
alongside designate-manage:
openstack dns pool list [--name <name>]
openstack dns pool show <pool>
`pool show` exposes `domain_id` and `shared`, enough to inspect a pool
before sharing it.
Also wire up the pool sharing API (/v2/pools/{pool_id}/shares):
openstack dns pool share create|list|show|delete <pool> ...
so a domain can use a pool owned by another domain without touching
designate-manage. Create/update/delete for pools is intentionally omitted.
Signed-off-by: Mikhail Samoylov <mikhailsamoiloff@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pool lifecycle is owned by
designate-manage pool, so upstream carries no pool commands in the client and the pool create/update/delete API methods are deprecated. Restore only the read-only surface that is safe to use alongside designate-manage:openstack dns pool list [--name ]
openstack dns pool show
pool showexposesdomain_idandshared, enough to inspect a pool before sharing it.Also wire up the pool sharing API (/v2/pools/{pool_id}/shares):
openstack dns pool share create|list|show|delete ...
so a domain can use a pool owned by another domain without touching designate-manage. Create/update/delete for pools is intentionally omitted.