Allow search archive results with error fields#24
Draft
nya-a-cat wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17.
Search archive responses can return HTTP 200 with a top-level
errorfield when the archived search itself failed. The client currently raisesSerpApiErrorfor those responses, which prevents callers from inspecting failed archived searches.This change keeps the behavior scoped to
search_archive: archived200 + errorJSON responses are returned, while regular search responses and non-200 archive responses still raise.I noticed #22 also touched this behavior, but that PR was closed unmerged and included several unrelated changes. This PR keeps the fix scoped to #17 only.
Tested:
rspec spec/serpapi/client/search_archive_error_handling_spec.rb --format documentationruby -c lib/serpapi/client.rbruby -c spec/serpapi/client/search_archive_error_handling_spec.rb