improvement(settings): right-align timezone picker, order by popularity, drop tooltip#5043
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview The timezone row is laid out like Theme and Snap to grid: the Reviewed by Cursor Bugbot for commit a38d548. Configure here. |
Greptile SummaryThis PR makes three focused improvements to the Settings → General timezone picker: it fixes a flex layout bug that left the combobox stuck to the left, re-orders the option list to surface common zones first, and removes the info-icon tooltip.
Confidence Score: 5/5Safe to merge — two isolated, self-contained changes (a flex wrapper and a new utility function) with no impact on data persistence or shared logic. Both changes are narrow in scope. The new getTimezonesByPopularity() correctly handles the full Intl.supportedValuesOf path and the Safari fallback, the layout wrapper resolves the alignment regression without touching any state or API logic, and the tooltip removal is a deliberate UX simplification. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "improvement(settings): right-align timez..." | Re-trigger Greptile |
Summary
(GMT±HH:MM) City(e.g.(GMT-07:00) Los Angeles), with the offset computed live so it tracks DST automatically. The list is sorted west→east by current UTC offset (ties alphabetical). One consistent format for every zone — no hardcoded, DST-naive abbreviations. Persisted values remain canonical IANA ids — backward compatibleChipComboboxin a fixedw-[260px]flex child — the combobox's internalw-fullwrapper was eating the row sojustify-betweenhad nothing to push against, leaving the pill stuck left while Theme/Snap-to-grid (ChipSelect) hugged the rightType of Change
Testing
Tested manually;
timezone.test.ts(24 tests) passing —(GMT±HH:MM) Cityformat, west→east offset ordering, live DST-aware offsets, no duplicate valuesChecklist