[Gear] Trinket - Gebbo's Bottomless Bag#11530
Conversation
|
need the spell ids for the trinket to work properly rotting voidfin - 1308014 if these arent currently in our spell dumps, they would need to be added to the generator.py file in dbc_extract3 before implementing the trinket. a lot of the stuff you manually coded wouldnt be needed once linked to the proper spells. |
|
Alright. Am i able to run the generator myself or how does that work? |
|
can run the generator if you've got the db2's and dbcache. db2s can be gotten with the casc_extract tool, while the dbcache is either taken from your own wow installs adb folder for the specific game version you're working on (ptr in this case) or just downloading the latest from the raidbots hotfix watcher. more info can be found here https://github.com/simulationcraft/simc/wiki/Using-CASC-Extract-and-DBC-Extract |
|
May i kindly ask you to do that this time around? I've added the spells to this PR |
|
can go ahead and remove the spells from the generator here to prevent a merge conflict, ill regenerate the data with them shortly. |
|
Done! Thanks a bunch |
|
4d55cb9 added the spells. youll need to do some refactoring to account for them. |
|
Should be good now. Also some stuff to make it display nicely in the html report aswell (the salmon name) |
Behavior of effects are from ingame testing since spelldata is lacking, but they're pretty simple.