[Gear] Trinket - Fang of Umbral Malignance#11534
Open
criller7070 wants to merge 4 commits into
Open
Conversation
criller7070
force-pushed
the
fang-of-umbral-malignance_implementation
branch
2 times, most recently
from
f7b5477 to
d59fd1c
Compare
criller7070
force-pushed
the
fang-of-umbral-malignance_implementation
branch
from
d59fd1c to
c13bc36
Compare
nyterage
requested changes
Jun 25, 2026
| dot->base_td = e.driver()->effectN( 1 ).average( e ); | ||
| dot->base_td_multiplier *= role_mult( e ); | ||
| dot->add_child( burst_action ); | ||
| target_debuff = e.player->find_spell( 1305853 ); |
Member
There was a problem hiding this comment.
i don't see any reason why you'd need the debuff here? the DoT already handles everything? i dont see it being used for anything here
Contributor
Author
There was a problem hiding this comment.
the intention was to make the log clearer in showing the debuff stacks.
Member
There was a problem hiding this comment.
the DoT already has the stack data. Shouldn't need to add an extra debuff to get stack data from that. having a secondary stacking effect being created on every target is also a performance concern when dot/debuff data is lazily initialized, only created when its first applied, basically costing 2x the initialization for every target its ever applied to during runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.