Skip to content

Add multiple new icons#476

Open
paulober wants to merge 1 commit into
skiptools:mainfrom
paulober:fix/android-bookmark-icon
Open

Add multiple new icons#476
paulober wants to merge 1 commit into
skiptools:mainfrom
paulober:fix/android-bookmark-icon

Conversation

@paulober

@paulober paulober commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device
  • REQUIRED: I have checked whether this change requires a corresponding update in the Skip Fuse UI repository (link related PR if applicable)
  • OPTIONAL: I have added an example of any UI changes to the Showcase sample app

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Used Claude Code to identify that the missing icons were on the classpath
via material-icons-extended but not wired into composeSymbolName/
composeImageVector.


Summary

Adds 5 SF-Symbol-name mappings that were missing from the curated Android
icon table in Image.swift. All backed by material-icons-extended, which
is already an api() dependency of this module — the classes were simply
never added to the curated symbol-name switch.

  • bookmark / bookmark.fill -> Icons.Outlined.BookmarkBorder / Icons.Filled.Bookmark
  • person.text.rectangle / barcode -> Icons.Outlined.Badge
  • camera.viewfinder -> Icons.Outlined.QrCodeScanner
  • barcode.viewfinder -> Icons.Outlined.CropFree
  • chart.bar.xaxis -> Icons.Outlined.BarChart

Android-only: composeSymbolName/composeImageVector live entirely inside
the transpile-mode #if SKIP block, never compiled for iOS/macOS — this
cannot affect Apple platforms.

@cla-bot cla-bot Bot added the cla-signed label Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant