feat: update app manifest to use agent_view#129
Draft
mwbrooks wants to merge 1 commit into
Draft
Conversation
Flips all three Casey implementations from assistant_view to agent_view in preparation for the new Agent DM Messages Tab experience: - Rename features.assistant_view -> features.agent_view in every manifest, and the inner assistant_description -> agent_description. - Remove assistant_thread_started from event subscriptions. - Merge set_suggested_prompts into app_home_opened, gated on event["tab"] so the Home tab keeps publishing its Block Kit view (category buttons + MCP status) and the Messages tab pins the suggested prompts. - Delete the now-unused assistant_thread_started.py handlers and refresh tests to cover both tab branches. The handler now calls client.assistant_threads_setSuggestedPrompts directly (the set_suggested_prompts middleware helper is only injected for assistant_thread_started). TODO(agent-dm-messages-tab) markers note where app_context_changed wiring will land once Bolt exposes the event type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request flips all three Casey implementations from
assistant_viewtoagent_viewto opt into the new Agent DM Messages Tab experience.features.assistant_view→features.agent_viewin every manifest, and the innerassistant_description→agent_description.assistant_thread_startedfromsettings.event_subscriptions.bot_events.set_suggested_promptslogic into theapp_home_openedhandler, gated onevent["tab"]: the Home tab keeps publishing its Block Kit view (category buttons + MCP status), the Messages tab pins the suggested prompts.assistant_thread_started.pyhandler files.tests/test_app_home_opened.pyto cover bothevent["tab"]branches.TODO(agent-dm-messages-tab)markers placed whereapp_context_changedwiring will land once Bolt for Python exposes the event type. That work is deferred to a follow-up PR.Implementation note: Bolt's
set_suggested_promptsmiddleware helper is only injected forassistant_thread_started, so the handler now callsclient.assistant_threads_setSuggestedPromptson theWebClient/AsyncWebClientdirectly.Files touched per implementation:
claude-agent-sdk/(async)manifest.json—agent_viewrename, dropassistant_thread_startedsubscriptionlisteners/events/app_home_opened.py— branch onevent["tab"]listeners/events/__init__.py— drop assistant-thread registrationlisteners/events/assistant_thread_started.py— deletedtests/test_app_home_opened.py— cover both branchesopenai-agents-sdk/(sync) — same change setpydantic-ai/(sync) — same change setTesting
Manual verification before review:
cd claude-agent-sdk && pip install -r requirements.txt && ruff check . && ruff format --check . && pytestcd openai-agents-sdk && pip install -r requirements.txt && ruff check . && ruff format --check . && pytestcd pydantic-ai && pip install -r requirements.txt && ruff check . && ruff format --check . && pytestpython app.pyfrom each subfolder fails only on missing tokens/provider keys (event listeners register without throwing).