Make the plugin ready for the new data model#3
Draft
zyzzyxdonta wants to merge 7 commits into
Draft
Conversation
Collaborator
Author
|
Hey @notactuallyfinn, here is another case where @SKernchen and I refactored a HERMES plugin to use the new data model. Would you be willing to take a look at the code to see if this makes sense? Thanks! 😄 |
notactuallyfinn
left a comment
notactuallyfinn
left a comment
There was a problem hiding this comment.
Looks good to me, only a few very minor things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Known bug: The new data model uses
schema: <http://schema.org/>while rdflib used in the validation code usesschema: <https://schema.org/>which causes validation to be skipped for all non-https things.