Defer default otel_resource creation in SolarWindsApmConfig.__init__#808
Draft
tammy-baylis-swi with Copilot wants to merge 3 commits into
Draft
Defer default otel_resource creation in SolarWindsApmConfig.__init__#808tammy-baylis-swi with Copilot wants to merge 3 commits into
otel_resource creation in SolarWindsApmConfig.__init__#808tammy-baylis-swi with Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comment for pull request 807
Defer default Jul 9, 2026
otel_resource creation in SolarWindsApmConfig.__init__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the single review comment on PR #807: avoid evaluating
Resource.create()in the constructor signature and apply the requested initialization pattern directly. The change is scoped to that comment only.Default argument behavior
SolarWindsApmConfig.__init__:otel_resource: Resource = Resource.create()otel_resource: Optional[Resource] = NoneRuntime initialization
otel_resource:if otel_resource is None: otel_resource = Resource.create()Typing/docstring alignment
None-default semantics while keeping backward-compatible behavior.