Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/modules/hbase/examples/getting_started/hdfs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
name: simple-hdfs
spec:
image:
productVersion: 3.4.2
productVersion: 3.5.0
clusterConfig:
dfsReplication: 1
zookeeperConfigMapName: simple-hdfs-znode
Expand Down
2 changes: 1 addition & 1 deletion docs/modules/hbase/examples/getting_started/hdfs.yaml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
name: simple-hdfs
spec:
image:
productVersion: 3.4.2
productVersion: 3.5.0
clusterConfig:
dfsReplication: 1
zookeeperConfigMapName: simple-hdfs-znode
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ spec:
- name: AWS_ENDPOINT
value: https://s3endpoint:9000/
- name: AWS_SSL_ENABLED
value: true
value: "true"
- name: AWS_PATH_STYLE_ACCESS
value: true
value: "true"
- name: AWS_ACCESS_KEY_ID
valueFrom:
secretKeyRef:
Expand Down

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes intentional? If so, what is the reason for it?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I had that in my local filesystem from a few weeks ago.
It actually fixes the YAML, it was an invalid manifest before (bool vs string)

Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ spec:
- name: AWS_ENDPOINT
value: https://s3endpoint:9000/
- name: AWS_SSL_ENABLED
value: true
value: "true"
- name: AWS_PATH_STYLE_ACCESS
value: true
value: "true"
- name: AWS_ACCESS_KEY_ID
valueFrom:
secretKeyRef:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ apiVersion: v1
kind: Secret
metadata:
name: s3-credentials
data:
stringData:
access-key-id: myS3AccessKeyId
secret-key: myS3SecretKey
4 changes: 3 additions & 1 deletion tests/test-definition.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@ dimensions:
- name: hdfs
values:
- 3.4.2
- 3.4.3

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I somehow managed to delete your comment. Given HBase is highly dependent on HDFS you convinced me to also test that ;)

Suggested change
- 3.4.3
- 3.4.2
- 3.4.3

- 3.5.0
- name: hdfs-latest
values:
- 3.4.2
- 3.5.0
- name: zookeeper
values:
- 3.9.4
Expand Down
Loading