build(deps)!: update protobuf from v3 to v4#962
Merged
Conversation
Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
bestbeforetoday
changed the title
Member
|
I feel that to be safe we should announce the major version increase as a BREAKING CHANGE since consumers of substrait-java might have re-declared the protobuf dependency with v3, pinned it to v3 or depend on v3 specific features in their code. |
bestbeforetoday
changed the title
nielspardon
approved these changes
Jun 30, 2026
nielspardon
left a comment
nielspardon
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for adding the breaking change message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Protobuf bindings are now generated using the v4 protobuf libraries, released in March 2024. Ensure that dependent projects also use the v4 protobuf-java libraries, and be aware of the breaking changes within the protobuf-java APIs documented at https://protobuf.dev/news/v26/#java-breaking-changes