fix: preserve verify_jwt setting when not in config.toml#5348
Open
deepshekhardas wants to merge 4 commits into
Open
fix: preserve verify_jwt setting when not in config.toml#5348deepshekhardas wants to merge 4 commits into
deepshekhardas wants to merge 4 commits into
Conversation
Changes VerifyJWT field from bool to *bool so the CLI can distinguish between 'not configured' and 'explicitly set to false'. When verify_jwt is not present in config.toml, the field is omitted from deploy metadata (nil), allowing the API to preserve the existing server-side setting instead of defaulting to true and overwriting the dashboard value. Fixes #43608
jgoux
force-pushed
the
fix/verify-jwt-deploy-preserve
branch
from
3136caa to
673d81f
Compare
jgoux
force-pushed
the
fix/verify-jwt-deploy-preserve
branch
from
673d81f to
bec2dd3
Compare
The shared deploy path now lists remote functions to preserve the server-side verify_jwt when it is not configured locally. The legacy deploy integration tests did not mock the new GET /functions call, so it fell through to a 404/201 response and the deploy failed. Mock the list call and assert on the deploy request directly instead of by index. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Changes the unction.VerifyJWT field from �ool to *bool across the codebase to distinguish between "not configured" and "explicitly set to false".
Files modified
Rationale
Previously, the CLI always sent �erify_jwt: true in deploy metadata for functions not listed in config.toml, overwriting the dashboard setting. With this fix, when �erify_jwt is not specified in config.toml, the field is omitted from the deploy payload (
il), allowing the API to preserve the existing server-side value.
Fixes #43608