fix: rewire postgresVersion input in pg_upgrade publish workflows#2225
Draft
jfreeland wants to merge 2 commits into
Draft
fix: rewire postgresVersion input in pg_upgrade publish workflows#2225jfreeland wants to merge 2 commits into
jfreeland wants to merge 2 commits into
Conversation
pcnc
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The
postgresVersionworkflow_dispatchinput was left as dead code after #2035 . The input is accepted but silently ignored. The workflows always readpostgres_majorandpostgres_releasefrom the current checkout'sansible/vars.yml.The same issue exists in both
publish-nix-pgupgrade-scripts.ymlandpublish-nix-pgupgrade-bin-flake-version.ymlWhat is the new behavior?
When
postgresVersionis set (viaworkflow_dispatchorgh workflow runfromami-release-nix.yml), it is treated as a bare git tag name (e.g.17.6.1.137,15.14.1.137). The workflow:git rev-parse --verify), failing with a clear error if notpostgres_majorfrom that tag'sansible/vars.ymlto determine which versions to iterate overpostgres_releasefrom that tag'sansible/vars.ymlto determine S3 path version stringsWhen postgresVersion is not set, behavior is unchanged. We read from the current checkout's
ansible/vars.yml.Additional context
This enables publishing updated
pg_upgradescripts for historical releases whoseansible/vars.ymlmay have had a different set of postgres versions. Handle input as environment variable to avoid shell injection and -eo pipefail to guard against null.