jextract/jni: Support escaping closures through @JavaInterface callbacks#813
Merged
ktoso merged 1 commit intoJul 3, 2026
Merged
Conversation
This is safe because we keep the java side object alive by capturing the JavaObjectHolder to it un the swift closure; so as long as Swift retains that holder, the Java object remains alive as well -- we cannot call on a freed java object. Reuses the existing JavaInterfaceProtocolWrapperGenerator without going through the whole wrap-java route, since we know both sides and what to generate for it. This means that this works even with the sandbox enabled. The java side just get a functional interface they can invoke, and rather than upcalling into it directly, we use the java interface Swift wrapper to make the upcall. resolves swiftlang#328
ktoso
changed the title
Collaborator
Author
|
Meh, still some things I'm not happy with that I missed, marking as draft |
ktoso
commented
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is safe because we keep the java side object alive by capturing the JavaObjectHolder to it un the swift closure; so as long as Swift retains that holder, the Java object remains alive as well -- we cannot call on a freed java object.
Reuses the existing
JavaInterfaceProtocolWrapperGeneratorwithout going through the whole wrap-java route, since we know both sides and what to generate for it. This means that this works even with the sandbox enabled.The java side just get a functional interface they can invoke, and rather than upcalling into it directly, we use the java interface Swift wrapper to make the upcall.
resolves #328
cc @madsodgaard