jextract/jni: Add support for returning protocols#814
Merged
Conversation
madsodgaard
changed the title
ktoso
reviewed
Jul 6, 2026
ktoso
reviewed
Jul 6, 2026
ktoso
approved these changes
Jul 6, 2026
ktoso
left a comment
ktoso
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for cleaning up the comments a bit; logic looks good, I'll want to do some restructuring since we're a bit repetetive sometimes.
LGTM tho
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for returning
any P / some Pfrom a function, variable etc...This is done by generating a
<P>Boxinstance in Java, that makes downcalls by opening the existential and calling a cdecl. This box implements both all protocol requirements and any inherited protocol requirements.One special thing is for
setters, where we need to do a "load-mutate-store", because it might be a value type.Closes #380