fix(web): restrict browser CORS origins#150
Open
leemeo3 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #135.
This tightens the local web API's browser CORS policy so JSON API responses no longer advertise
Access-Control-Allow-Origin: *. Browser requests with anOriginheader are now limited to loopback origins (localhost,127.0.0.1,[::1]), and non-loopback origins receive a 403 response without CORS allow headers.Why
The web UI/API is a local developer tool, but the previous wildcard CORS response allowed arbitrary websites visited in the same browser to make credentialless cross-origin requests to the local memory API. This PR keeps non-browser/local tool requests working while preventing random web origins from reading or mutating local memories through CORS.
Scope
web-server.tsand the worker implementation.This intentionally does not close #135 because that issue also tracks other security items, including auth and persistent prompt-injection hardening.
Validation
npx bun test tests/web-server-cors.test.tsnpx bun run typechecknpx bun run buildnpx bun test— 161 pass, 0 failAI assistance disclosure: this PR was prepared with Codex assistance and reviewed before submission.