[pull] master from php:master#1005
Merged
Merged
Conversation
* PHP-8.4: ext/openssl: openssl_encrypt() zend mm heap overflow on AES-WRAP-PAD mode.
* PHP-8.5: ext/openssl: openssl_encrypt() zend mm heap overflow on AES-WRAP-PAD mode.
The getHash() recursion guard increments a request-persistent counter around the userland getHash() call but decrements it only on the normal return path. A bailout inside an overridden getHash() (out-of-memory, timeout, or any fatal) skips the decrement, and the counter is never reset per request, so on a persistent SAPI every later request on the same worker wrongly throws "Modification of SplObjectStorage during getHash() is prohibited". Reset the counter in the SPL request init so each request starts at zero regardless of how the previous one exited. Closes GH-22308
php_head_parse_cookie_options_array() matches option keys case insensitively, but array keys are case sensitive, so a duplicate differing only in case (e.g. "path" and "Path") overwrote the previously fetched path/domain/samesite string without releasing it. Release any value already stored before fetching the next one. Closes GH-22309
* PHP-8.4: Fix zend_string leak on case-variant duplicate setcookie() options
* PHP-8.5: Fix zend_string leak on case-variant duplicate setcookie() options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )