[pull] master from php:master#999
Merged
Merged
Conversation
The reason fake closures didn't compare as equal was that two different objects could represent the same fake closure. Therefore, we need to do a more detailed comparison when one or both operands are closures rather than just comparing pointers. A good follow-up would be to draft an RFC to fix the semantics of `==` with two different instances of the same fake closure.
Fixed the canonical case of the magic method `__debugInfo()` + organized all macros of magic methods with the separation of canonical and lowercase versions.
The `{0x45, 0x78, 0x69, 0x66, 0x00, 0x00}` arrays are the ASCII bytes for
`"Exif\0\0";` the char form is byte-identical and self-documenting.
Follow up to #22247 SKIPIF condition should indeed exit the process to signal a problem.
…1956) That allows reliable usage of the `GC_*()` macros in (inline) functions in zend_types.h.
`vptr` points to the current value being iterated over, not `value`, see other switch cases. Closes GH-22249.
* PHP-8.4: exif: read from the correct pointer
* PHP-8.5: exif: read from the correct pointer
This function was missing for consistency with the other functions which all have a `cstr` variant. Adding this function also made it easy to convert some more copy-and-pasted logic.
Based on Nora's suggestion of not using an unnecesary allocation.
- static modifier is added for php_uri_parser_rfc3986_parse() - const modifier is added for component read and write handler parameters
* zend_observer: Convert `ZEND_OBSERVER_HANDLE()` to inline function * zend_observer: Convert `ZEND_OBSERVER_FCALL_(BEGIN|END)()` to inline functions
…ons (#22297) `zend_free_trampoline()` requires access to the globals and thus cannot easily be made an inline function without moving it to a different (less-appropriate) header. Since trampolines should be comparatively rare, having an extra function call here should be okay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )