Add CS Tresca and 2D contour plots#4325
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4325 +/- ##
==========================================
- Coverage 48.82% 48.58% -0.25%
==========================================
Files 151 151
Lines 29405 29660 +255
==========================================
+ Hits 14358 14409 +51
- Misses 15047 15251 +204 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…e stress yield locus plotting
…ofiles for radial and hoop stress
… peak axial stress section
…Solenoid stress variables across multiple files
… in Central Solenoid constraints
…Solenoid stress variables across multiple data files
…iveMethodType check for beam parameters
…s and updating formula
…ions for clarity and simplification
…profile and enhancing radial stress profile visualization
…yield locus function
f85f77d to
f4de71f
Compare
…ial in input data files
timothy-nunn
left a comment
There was a problem hiding this comment.
Will await Jack's review on model and docs changes and figure correctness before further review.
| np.linspace( | ||
| -self.data.pf_coil.z_cs_upper, | ||
| self.data.pf_coil.z_cs_upper, | ||
| num=20, |
There was a problem hiding this comment.
Again, is this 20 related to the profile length? If it is, and the profile length could change in future, its probably best to use the length of the profile array here
There was a problem hiding this comment.
There is no profile object at the moment it is just a initial generic number
| "W_", | ||
| ] | ||
| lzdata = [0.0 for x in range(len(label))] | ||
| _ = _skiprows |
There was a problem hiding this comment.
This statement doesn't make any sense
There was a problem hiding this comment.
Can you check the sanity of this, I cant remember when it went in. _skiprows is currently passed in as an argument.
Co-authored-by: Timothy <75321887+timothy-nunn@users.noreply.github.com>
j-a-foster
left a comment
There was a problem hiding this comment.
Happy with docs and model.
Co-authored-by: Timothy <75321887+timothy-nunn@users.noreply.github.com>
This pull request makes significant improvements to the central solenoid (CS) stress modeling, variable naming consistency, and documentation. The main changes include refactoring variable names for clarity, adding new stress calculation methods (Tresca and von Mises), expanding the CS stress data model, and updating documentation to match the new, more general approach to CS stress calculations.
Central Solenoid Stress Modeling and Calculations:
materials.py, enabling more comprehensive CS stress analysis.PFCoilDataclass to include vertical profiles of axial stress, radial stress (peak and inner), and von Mises stress for the central solenoid.i_cs_stressswitch, reflecting a shift to always considering both hoop and axial stresses.Variable Naming Consistency and Refactoring:
alstrohtostress_cs_steel_maxthroughout the codebase, input files, and documentation for clarity and consistency.Documentation Updates:
i_cs_stressswitch and clarified the use of Tresca and von Mises criteria.These changes modernize the CS stress model, improve clarity for users and developers, and lay the groundwork for more advanced stress analysis and postprocessing.
Checklist
I confirm that I have completed the following checks: