Add new negative triangularity confinement time scaling by ajpearcey · Pull Request #4386 · ukaea/PROCESS

ajpearcey · 2026-06-25T15:22:10Z

resolves #3825

codecov-commenter · 2026-06-25T15:33:00Z

Codecov Report

❌ Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.83%. Comparing base (024a2f2) to head (4f56b95).

Files with missing lines	Patch %	Lines
process/models/physics/confinement_time.py	76.92%	3 Missing ⚠️
process/core/io/plot/summary.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4386   +/-   ##
=======================================
  Coverage   48.83%   48.83%           
=======================================
  Files         151      151           
  Lines       29397    29403    +6     
=======================================
+ Hits        14356    14360    +4     
- Misses      15041    15043    +2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

timothy-nunn

Just one minor style comment. Will ask @chris-ashe to review (or he can suggest someone else)

chris-ashe · 2026-06-26T09:51:31Z

 [^22]: G. Verdoolaege et al., “The updated ITPA global H-mode confinement database: description and analysis,” Nuclear Fusion, vol. 61, no. 7, pp. 076006-076006, Jan. 2021, doi: https://doi.org/10.1088/1741-4326/abdb91.
-[^23]: H. Lux, R. Kemp, E. Fable, and R. Wenninger, “Radiation and confinement in 0D fusion systems codes,” Plasma Physics and Controlled Fusion, vol. 58, no. 7, pp. 075001–075001, May 2016, doi: https://doi.org/10.1088/0741-3335/58/7/075001.
-[^24]: H. Lux, R. Kemp, D. J. Ward, and M. Sertoli, “Impurity radiation in DEMO systems modelling,” Fusion Engineering and Design, vol. 101, pp. 42–51, Dec. 2015, doi: https://doi.org/10.1016/j.fusengdes.2015.10.002.
+[^23]: P. Lunia, A.O. Nelson, and C. Paz-Soldan, "Energy Confinement Time Scaling Law Derived from Paz-Soldan NF 2024", doi: https://arxiv.org/abs/2509.04279v2


Can I ask that the references now actually have a descriptive title such as [^paz_soldan_neg]

chris-ashe · 2026-06-26T09:52:22Z

    NSTX_GYRO_BOHM = (48, "Buxton NSTX gyro-Bohm      (ST)(H)")
    ITPA20 = (49, "ITPA20                         (H)")
    ITPA20_IL = (50, "ITPA20-IL                      (H)")
+    PAZ_SOLDAN_NT = (51, "Paz-Soldan Neg Triang         (L)")


Suggested change

PAZ_SOLDAN_NT = (51, "Paz-Soldan Neg Triang (L)")

PAZ_SOLDAN_NT = (51, "Paz-Soldan Negative δ (L)")

chris-ashe · 2026-06-26T10:05:22Z

+        p_plasma_loss_mw :
+            Thermal power lost due to transport through the LCFS [MW]
+        dnla19 :
+            Central line-averaged electron density in units of 10**19 m**-3


Suggested change

Central line-averaged electron density in units of 10**19 m**-3

Central line-averaged electron density in units of 10¹⁹/m³

chris-ashe · 2026-06-26T10:11:38Z

+
+        References
+        ----------
+        Priyansh Lunia, A.O. Nelson, and C. Paz-Soldan, "Energy Confinement Time


Reference should be written as:

[1] Priyansh Lunia, A.O. Nelson, and C. Paz-Soldan, "Energy Confinement Time Scaling Law Derived from Paz-Soldan NF 2024",
doi: https://arxiv.org/abs/2509.04279v2

The text should be left aligned with the left bracket of the [1] in order for it to preview properly in the IDE.

This is the Numpy Standard:
https://numpydoc.readthedocs.io/en/latest/format.html#references

chris-ashe · 2026-06-26T10:16:58Z

+            0.0821
+            * pcur**1.02
+            * b_plasma_toroidal_on_axis**0.11
+            * dnla19**0.51


Looking at the reference is this actually meant to be the line averaged or volume averaged?. Also is it meant to be in x20 or x19?

chris-ashe · 2026-06-26T10:20:38Z

Am confused as to why the regression tests are failing here @timothy-nunn

timothy-nunn · 2026-06-29T12:28:19Z

        # If stellarator, use the stellarator scalings
        for i_confinement_time in (
-            range(1, N_CONFINEMENT_SCALINGS) if istell == 0 else stellarator_scalings
+            range(1, N_CONFINEMENT_SCALINGS + 1) if istell == 0 else stellarator_scalings


Shouldn't N_CONFINEMENT_SCALINGS be incremented by 1 rather than adding 1 here?

Just realised that its not changed. Thought it was. The above should go then.
@timothy-nunn Surely we can have N_CONFINEMENT_SCALINGS set automatically?

I can see, only thing would be it might cause circular imports

Something like #4397 ?

timothy-nunn · 2026-06-29T14:26:58Z

Am confused as to why the regression tests are failing here @timothy-nunn

@chris-ashe could it be #4396 ?

timothy-nunn

Happy with the code, will await @chris-ashe approval before merging. Do you want #4396 to go in first to stop a random confinement scaling being used for the hstar in the MFile?

chris-ashe · 2026-07-02T09:54:35Z

Will wait for rebase to fix merge conflict before doing re-review. The enum has changed so your entry will need to be adapted @ajpearcey

chris-ashe

Some previous suggestions still haven't been addressed. Need to ensure c_plasma_ma -> cur_plasma_ma as per the style guide.

chris-ashe · 2026-07-02T12:08:46Z

    # Calculate confinement times using the scan data
    iter_89p = confine.iter_89p_confinement_time(
-        pcur=c_plasma_ma,
+        c_plasma_ma=c_plasma_ma,


Renaming of pcur to c_plasma_ma does not match the style guide. It should be cur_plasma_ma

We where already using c_plasma_ma in the other parts of the documentation? c_plamas_ma is given in the example naming conventions.

Seems to be the refernce at the bottom was not updated.
The standard as it stands is cur_
https://ukaea.github.io/PROCESS/development/standards/#currents

I will put an issue in to replace the example

I would also note that you'd need to update things like f_c_plasma_bootstrap, f_c_plasma_auxiliary, f_c_plasma_inductive and many more. I feel like this is taking this outside the scope of this PR.

Yes that change needs to happen, don't worry about it in this case as you haven't touched those in this PR already

ajpearcey requested a review from a team as a code owner June 25, 2026 15:22

ajpearcey changed the title ~~WIP: Add new negative triangularity confinement time scaling~~ Add new negative triangularity confinement time scaling Jun 25, 2026

timothy-nunn requested a review from chris-ashe June 26, 2026 07:40

timothy-nunn self-assigned this Jun 26, 2026

timothy-nunn reviewed Jun 26, 2026

View reviewed changes

Comment thread process/models/physics/confinement_time.py Outdated

chris-ashe requested changes Jun 26, 2026

View reviewed changes

timothy-nunn reviewed Jun 29, 2026

View reviewed changes

ajpearcey force-pushed the issue-3825-new-neg-triang-confinement-time branch 2 times, most recently from e01d349 to 2fc9420 Compare June 30, 2026 12:33

timothy-nunn reviewed Jul 1, 2026

View reviewed changes

apearce added 5 commits July 2, 2026 11:17

✨ at Paz-Soldan NT confinement time scaling

85d0475

🎨 update following comments

6ca2937

🎨 update syummary variable names

368ea70

🎨 unify plasma current variable name

f42419e

🎨 update variables after rebase

4f56b95

ajpearcey force-pushed the issue-3825-new-neg-triang-confinement-time branch from 457b046 to 4f56b95 Compare July 2, 2026 10:22

chris-ashe requested changes Jul 2, 2026

View reviewed changes

	PAZ_SOLDAN_NT = (51, "Paz-Soldan Neg Triang (L)")
	PAZ_SOLDAN_NT = (51, "Paz-Soldan Negative δ (L)")

	Central line-averaged electron density in units of 1019 m-3
	Central line-averaged electron density in units of 10¹⁹/m³

Uh oh!

Conversation

ajpearcey commented Jun 25, 2026

Uh oh!

codecov-commenter commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

timothy-nunn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chris-ashe Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chris-ashe commented Jun 26, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

timothy-nunn commented Jun 29, 2026

Uh oh!

timothy-nunn left a comment

Choose a reason for hiding this comment

Uh oh!

chris-ashe commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chris-ashe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ajpearcey Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Jun 25, 2026 •

edited

Loading

chris-ashe Jun 26, 2026 •

edited

Loading

chris-ashe commented Jul 2, 2026 •

edited

Loading

ajpearcey Jul 2, 2026 •

edited

Loading