[WIP] Add programmatic composite unit builder#72
Draft
suleman-uzair wants to merge 2 commits into
Draft
Conversation
added 2 commits
July 1, 2026 23:08
Compose units from parts instead of only parsing strings. Adds the multiplication and division operator DSL (on Unit, Dimension and Formula via a Composable mixin) and the Unitsml.compose keyword form, both producing a Formula whose output matches the equivalent parsed string across every format. Units are referenced by symbol id or short name, powers come from the constructor, and quantity/name/multiplier metadata are passed to the render methods. Also resolves quantities by name and short slug (Quantities#find_by_name) and emits a canonical Quantity element with the NIST xml:id, quantityType and dimensionURL. Implements #2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds programmatic creation of composite units, in addition to
Unitsml.parse, using multiplication/division operators and theUnitsml.composemethod. The generated Formula matches the equivalent parsed-string output in all supported conversions.Units are referenced by symbol id (
"W") or short name ("watt"), and unknown units/prefixes or mixing units with dimensions raiseUnitsml::Errors::*. This PR also updatesquantityresolution to support names and emits a canonical Quantity element (NIST id,quantityType,dimensionURL) in XML output.closes #2