Token harness refresh#125
Open
mdeyell-valid-mind wants to merge 10 commits into
Open
Conversation
4ce6954 to
41826ab
Compare
hunner
approved these changes
Jul 9, 2026
hunner
left a comment
Collaborator
There was a problem hiding this comment.
Solid, well-tested feature with unusually careful cache handling — the fresh-temp-file + atomic rename dance so 0600 actually applies, the sha256(command + URL) cache keying, the single-flight refresh promise, and the bounded one-shot 401 retry are all right. Enabling Pi in the integration harness so the full mint → cache → re-mint → 401-retry path is exercised end-to-end is great. Docs are accurate to the code (I verified the 55-minute default, skew, cache keying, mode, and retry semantics all match).
Approving with five issues and three nits inline — none blocking, but 1, 2, and 5 are small concrete fixes worth making before merge.
🤖 Automated reply
Contributor
Author
|
@hunner Thanks, I updated this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support to the agent harness integrations so short-lived OAuth access tokens can be refreshed automatically.
I tested this with
PI.When reviewing please look at the docs to make sure those are usable to you.
Changes
access_token,accessToken, ortokenexpires_in,expires_at, orexpiresAt