Skip to content

fix(cc): merge task-refactor into next#716

Open
rsarika wants to merge 8 commits into
nextfrom
task-refactor
Open

fix(cc): merge task-refactor into next#716
rsarika wants to merge 8 commits into
nextfrom
task-refactor

Conversation

@rsarika

@rsarika rsarika commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

< DESCRIBE THE CONTEXT OF THE ISSUE >

by making the following changes

< DESCRIBE YOUR CHANGES >

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
    < ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document
  • I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

akulakum and others added 7 commits May 27, 2026 14:12
Co-authored-by: Shreyas Sharma <shreyassharma9912@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Ritesh Singh <133033102+riteshfyi@users.noreply.github.com>
Co-authored-by: Vintha Vivekananda <151998489+vivekv1504@users.noreply.github.com>
Co-authored-by: Bharath Balan <62698609+bhabalan@users.noreply.github.com>
Co-authored-by: Kesava Krishnan Madavan <mkesavan13@gmail.com>
Co-authored-by: Kesari3008 <65543166+Kesari3008@users.noreply.github.com>
Co-authored-by: Matthew <matthew.olker@gmail.com>
Co-authored-by: molker <molker@cisco.com>
Co-authored-by: ciscoRankush <119413473+ciscoRankush@users.noreply.github.com>
Co-authored-by: ciscoRankush <ciscoRankush@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Rankush Kumar <rankkuma+cisco@cisco.com>
Co-authored-by: Govardhana vamshi <93788625+vamshigovardhana@users.noreply.github.com>
Co-authored-by: CM <cmullenx@gmail.com>
Co-authored-by: Christina Mullen <chrmulle@cisco.com>
Co-authored-by: rsarika <95286093+rsarika@users.noreply.github.com>
Co-authored-by: Zachary Raymer <zachraymer@gmail.com>
Co-authored-by: Zach Raymer <zraymer@cisco.com>
Co-authored-by: Akula Uday <akulakum@cisco.com>
@rsarika rsarika requested a review from a team as a code owner July 3, 2026 11:58
@aws-amplify-us-east-2

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-716.d1b38q61t1z947.amplifyapp.com

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b7e8ea5b91

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/deploy.yml Outdated
on:
push:
branches: # Allow list of deployable tags and branches. Note that all allow-listed branches cannot include any `/` characters
<<<<<<< next-in-task-refactor

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove unresolved conflict markers from deploy workflow

The Deploy CD workflow now contains raw merge-conflict markers under on.push.branches. On pushes to next or task-refactor, GitHub Actions parses this YAML before any job runs, and these markers make the workflow invalid, so the release/tag/docs deploy path will not start. I also checked for other conflict markers with rg --hidden and only this workflow is affected.

Useful? React with 👍 / 👎.

Comment on lines +688 to +690
const wrapupCallCallback = () => {
try {
const wrapUpReason = store.wrapupCodes.find((code) => code.id === wrapUpAuxCodeId)?.name;
if (onWrapUp) {
onWrapUp({
task: currentTask,
wrapUpReason: wrapUpReason,
});
if (lastWrapupAuxCodeIdRef.current) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Read the TASK_WRAPPEDUP payload before the ref

When TASK_WRAPPEDUP is emitted without this component's wrapupCall() running first, such as auto-wrapup or wrap-up initiated from another widget/session, the SDK event still carries the selected wrapUpAuxCodeId, but this handler now ignores the event payload and exits while lastWrapupAuxCodeIdRef is null. That means the public onWrapUp callback never fires for those completed wrap-ups; keep accepting the event payload and only fall back to the ref when needed.

Useful? React with 👍 / 👎.

Comment on lines +999 to +1003
const hasExistingLine = transcriptLines.some((line) => line.messageId === transcriptData.messageId);

this.store.realtimeTranscriptionData = hasExistingLine
? transcriptLines.map((line) =>
line.messageId === transcriptData.messageId ? {...line, ...newTranscriptData} : line

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Scope transcript lines by interaction

In multi-task sessions, realtime transcription listeners are registered for every task, but all events are merged into the singleton realtimeTranscriptionData and de-duped only by messageId. Because the new transcript widget later renders the whole singleton for whichever task is current, transcript lines from task B can appear while task A is selected, or overwrite task A's line if message IDs collide; include the interaction/conversation when storing and rendering these entries.

Useful? React with 👍 / 👎.

@akulakum akulakum added the validated Indicates that the PR is ready for actions label Jul 6, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 22ee800999

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +591 to +595
if (isCampaignPreview) {
this.setState({
developerName: RESERVED_LABEL,
name: RESERVED_USERNAME,
});

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Mark accepted preview reservations as accepted

When a standard/direct preview campaign emits the task-level TASK_CAMPAIGN_PREVIEW_RESERVATION after the agent accepts it, this handler now leaves the interaction in RESERVED and never adds the interaction id to acceptedCampaignIds. The task wrappers use that set as the source of truth to stop treating the preview as unaccepted, so the accepted preview can keep hiding CallControl and rendering as a pending preview instead of moving to engaged handling.

Useful? React with 👍 / 👎.

Comment on lines +83 to +86
const dnis =
currentTask?.data?.interaction?.callAssociatedDetails?.dnis ||
currentTask?.data?.interaction?.callProcessingDetails?.dnis;
const displayNumber = isOutdial ? dnis || ani : ani;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fall back to dn for outdial caller ID

For outdial CAD views where the SDK payload has the customer number in callAssociatedDetails.dn but no dnis field, this now displays ani (the agent/origin number) as the main caller identifier. The existing getCallerIdentifier contract in this package still documents outdial customer numbers as coming from dn, so include dn as a fallback before ani to avoid showing the wrong party on outdial calls.

Useful? React with 👍 / 👎.

@akulakum akulakum changed the title Task refactor fix(cc): merge task-refactor into next Jul 6, 2026
@akulakum akulakum added validated Indicates that the PR is ready for actions and removed validated Indicates that the PR is ready for actions labels Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated Indicates that the PR is ready for actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants