corridor: add strip, cross-backend, param, and metadata coverage#3448
Open
brendancol wants to merge 1 commit into
Open
corridor: add strip, cross-backend, param, and metadata coverage#3448brendancol wants to merge 1 commit into
brendancol wants to merge 1 commit into
Conversation
least_cost_corridor hands its backend math to cost_distance and otherwise does plain xarray arithmetic, so the existing suite already covered the four backends on the core paths. These tests close the gaps a deep-sweep audit found. Every path was probed first and already works, so this adds coverage rather than fixing bugs. Added (test-only): - Nx1 and 1xN strip rasters (degenerate kernel-boundary shapes) - numpy vs dask+numpy / cupy / dask+cupy equivalence check - connectivity=4 and a finite max_cost, both forwarded to cost_distance - attrs and coords preservation, plus custom lat/lon dim-name propagation 41 tests pass on a CUDA host. The cupy and dask+cupy cases ran on the GPU instead of being skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
least_cost_corridor hands its backend math to cost_distance and otherwise does plain xarray arithmetic, so the existing suite already covered the four backends on the core paths. These tests close the gaps a deep-sweep audit found. Every path was probed first and already works, so this adds coverage rather than fixing bugs.
Added (test-only):
41 tests pass on a CUDA host. The cupy and dask+cupy cases ran on the GPU instead of being skipped.