fix(server): adopt mcp-go v0.55 WithStreamableHTTPLogger API#72
Merged
Conversation
mcp-go v0.55 renamed the StreamableHTTP transport logger option from WithLogger to WithStreamableHTTPLogger and switched it to *slog.Logger (WithLogger now sets a server-level logger on the MCPServer). The dep bump (#69) left newStreamableHTTPServer calling the old signature, breaking the build on main. Switch to WithStreamableHTTPLogger(logger) and drop the now -obsolete slogAdapter shim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unbreaks
main: the mcp-go v0.55.1 bump (#69) renamed the StreamableHTTP transport logger optionWithLogger→WithStreamableHTTPLoggerand switched it to*slog.Logger.newStreamableHTTPServerstill called the old signature, failing the build across all platforms. This switches toWithStreamableHTTPLogger(logger)and drops the now-obsoleteslogAdaptershim.go build,go vet, andgo test ./pkg/... ./internal/...all pass locally on top of merged main.