Skip to content

fix(server): adopt mcp-go v0.55 WithStreamableHTTPLogger API #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ysyneu merged 1 commit into from
Jul 8, 2026
Merged

fix(server): adopt mcp-go v0.55 WithStreamableHTTPLogger API #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions internal/flashduty/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,6 @@ import (
"github.com/flashcatcloud/flashduty-mcp-server/pkg/translations"
)

// slogAdapter adapts slog.Logger to mcp-go's util.Logger interface
type slogAdapter struct {
logger *slog.Logger
}

func (a *slogAdapter) Infof(format string, v ...any) {
a.logger.Info(fmt.Sprintf(format, v...))
}

func (a *slogAdapter) Errorf(format string, v ...any) {
a.logger.Error(fmt.Sprintf(format, v...))
}

type FlashdutyConfig struct {
// Version of the server
Version string
Expand Down Expand Up @@ -148,7 +135,10 @@ func NewMCPServer(cfg FlashdutyConfig) (*server.MCPServer, error) {
func newStreamableHTTPServer(mcpServer *server.MCPServer, logger *slog.Logger, contextFunc server.HTTPContextFunc) *server.StreamableHTTPServer {
return server.NewStreamableHTTPServer(
mcpServer,
server.WithLogger(&slogAdapter{logger: logger}),
// mcp-go v0.55 renamed the transport logger option to
// WithStreamableHTTPLogger and switched it to *slog.Logger, so the
// former slogAdapter shim is no longer needed.
server.WithStreamableHTTPLogger(logger),
// Return 405 for GET requests — this server doesn't use server-initiated
// features (sampling, elicitation). Without this, the SDK's standalone SSE
// GET hangs indefinitely because mcp-go creates an orphan session and blocks.
Expand Down
Loading