fix: emit X-Glean-Include-Experimental header (not X-Glean-Experimental)#153
Merged
Merged
Conversation
The XGlean before_request hook read the correct include_experimental option and X_GLEAN_INCLUDE_EXPERIMENTAL env var but emitted the wrong header name. The backend expects X-Glean-Include-Experimental. Correct the header name in the hook and tests.
steve-calvert-glean
approved these changes
Jul 2, 2026
steve-calvert-glean
left a comment
steve-calvert-glean
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix, @travis-hoover-glean. Can we just make this a const so we don't have to update it in so many places?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
XGleanbefore_requesthook correctly reads theinclude_experimentalSDK option and theX_GLEAN_INCLUDE_EXPERIMENTALenv var, but sets the wrong header name. It emitsX-Glean-Experimentalwhen the backend expectsX-Glean-Include-Experimental.This corrects the header name in the hook and its tests. Behavior (opt-in, env var precedence) is unchanged.
Changes
src/glean/api_client/_hooks/x_glean.py— header name (and docstring)tests/test_x_glean_hook.py— updated assertionsVerification
poetry run pytest tests/test_x_glean_hook.py→ 15 passedRelated
Same bug exists in the TypeScript, Go, and Java SDKs; companion PRs fix each. Env var name was already correct and is unchanged.