fix(router): make exception page render in sandboxed/insecure environments#2200
Merged
innocenzi merged 3 commits intoJul 7, 2026
Conversation
sandboxed/insecure envs
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit d5c2cd1 |
brendt
approved these changes
Jul 7, 2026
brendt
left a comment
brendt
left a comment
Member
There was a problem hiding this comment.
LGTM. @innocenzi feel free to merge when you're ok with it
Member
|
LGTM, built the renderer, but that one test really doesn't wanna pass |
Member
|
I've been debugging this one, IDK why it happens, but it's unrelated to this PR. So feel free to merge |
Member
|
Thanks @NeoIsRecursive for taking care of this! |
NeoIsRecursive
deleted the
fix/make-exception-page-renderable-in-sandboxed-envs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have not built the assets, so that has to be done before merging :)
Before:
Skarminspelning.2026-07-06.kl.22.58.37.mov
After:
Skarminspelning.2026-07-06.kl.23.04.47.mov
Closes #2176