Skip to content

fix(router): make exception page render in sandboxed/insecure environments #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
innocenzi merged 3 commits into from
Jul 7, 2026
Merged

fix(router): make exception page render in sandboxed/insecure environments #2200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c941068
fix(router): fallback to in-memory storage when localStorage is
NeoIsRecursive Jul 6, 2026
4028bb5
fix(router): use memory history to prevent modifying history in
NeoIsRecursive Jul 6, 2026
d5c2cd1
chore: build exception renderer
innocenzi Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 36 additions & 36 deletions packages/router/src/Exceptions/local/dist/main.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions packages/router/src/Exceptions/local/src/entrypoint/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import ui from '@nuxt/ui/vue-plugin'
import { createApp } from 'vue'
import { createRouter, createWebHistory } from 'vue-router'
import { createMemoryHistory, createRouter } from 'vue-router'
import renderer from '../renderer.vue'
import { initializeExceptionStore } from '../store'
import './style.css'

const app = createApp(renderer)
const router = createRouter({
routes: [],
history: createWebHistory(),
history: createMemoryHistory(),
})

const element = document.getElementById('tempest-hydration')
Expand Down
14 changes: 11 additions & 3 deletions packages/router/src/Exceptions/local/src/settings/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useLocalStorage } from '@vueuse/core'
import { useOverlay, useToast } from '@nuxt/ui/composables'
import { useStorage } from '@vueuse/core'
import { type } from 'arktype'
import Dialog from './dialog.vue'
import { useOverlay, useToast } from '@nuxt/ui/composables';

const overlay = useOverlay()

Expand All @@ -15,7 +15,15 @@ export const schema = type({
export type Editor = typeof schema.infer['editor']
export type Settings = typeof schema.inferIn

export const settings = useLocalStorage<Settings>('tempest:exceptions:settings', {})
const tryGetLocalStorage = () => {
try {
return window.localStorage
} catch {
return
}
}

export const settings = useStorage<Settings>('tempest:exceptions:settings', {}, tryGetLocalStorage())

export async function openFileInEditor(file: string, line?: number) {
if (!settings.value.editor) {
Expand Down
Loading