DX-1128: docs local design foundation (vendor @ably/ui tokens + reset CSS)#3409
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
9793a26 to
53a85f2
Compare
53a85f2 to
1b58cba
Compare
|
@jamiehenson did you manage to rebase this after #3418 got merged? |
kennethkalmer
left a comment
There was a problem hiding this comment.
Extraction makes sense, poked around the review app and everything looked okay 🎨
Vendor @ably/ui's Tailwind theme (inlined into tailwind.config.js) + reset/core/ component CSS under src/styles/ui/. Full CSS + the @ably/ui content glob retained so each stacked PR stays self-sufficient; prune lands in the final PR.
1b58cba to
0452333
Compare
Part of DX-1128 / DXDR-005 (retire the shared
@ably/uipackage). Foundation PR — vendors@ably/ui's Tailwind theme + CSS into docs so the package is no longer the styling source.What
@ably/ui's base Tailwind config intotailwind.config.js— the theme (colours,ui-text-*typography, screens, keyframes, plugins) is now inlined here instead ofrequire('@ably/ui/tailwind.extend.js').src/styles/ui/(properties.csstoken vars,text/buttons/forms/shadows/utils, reset/normalize, Code/Slider/Flash component CSS, syntax-highlighter).global.css@imports these locally..prettierignore.Self-sufficiency
The
node_modules/@ably/uiTailwind content glob and the full vendored CSS are retained here, so this PR (and every PR up to #3415) is independently deployable — the still-present@ably/uicomponents in the early stack keep their utility classes. The dead-CSS prune + glob removal land in #3416 once everything is local.Behaviour
No visual change intended. Theme verified equal to
@ably/ui'sextendConfigoutput;global.csscompiles to ~8.4k lines with--color-*,ui-text-*,hljsall present.Stack (DX-1128)
@ably/uitokens + reset/core CSScn+heightsutilsIconcomponent@ably/uiTailwind scanmain)#3409–#3416 are a linear stack (each builds on the previous); #3417 is the combined view. ▶ = this PR.
Testing
🤖 Generated with Claude Code