DX-1128: docs — localise design system off @ably/ui (combined view for review/demo)#3417
Closed
jamiehenson wants to merge 8 commits into
Closed
DX-1128: docs — localise design system off @ably/ui (combined view for review/demo)#3417jamiehenson wants to merge 8 commits into
jamiehenson wants to merge 8 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
17d25cb to
2da466a
Compare
2da466a to
6dff760
Compare
6dff760 to
c1b3585
Compare
c1b3585 to
0dd3b59
Compare
This was referenced Jun 18, 2026
Merged
Merged
Vendor @ably/ui's Tailwind theme (inlined into tailwind.config.js) + reset/core/ component CSS under src/styles/ui/. Full CSS + the @ably/ui content glob retained so each stacked PR stays self-sufficient; prune lands in the final PR.
…Button/FeaturedLink/Status) (DX-1128)
…+ drop @ably/ui Tailwind scan (DX-1128)
edfcd5c to
106d06b
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of DX-1128. Combined view of the whole stack (#3409–#3416) on top of
main— for reviewing/demoing the localisation as one diff. Not for merge; the individual stacked PRs land it.What it does
Removes
@ably/uias docs' design-system source: vendors the Tailwind theme + CSS, a localIcon,cn/heights, and the full visual component set (Badge/Button/LinkButton/FeaturedLink/Status,SegmentedControl/TabMenu,ProductTile,Code/CodeSnippet), plus the syntax-highlighter util. (~169 files.)End state
Entire visual surface local; compiled
global.css6.7k lines. Remaining@ably/uiimports =insights(×6) +scripts(×2 — theSessionDataProvider/useSessionDatacontext API); the old SessionData Redux store +Flashreducer are gone after rebasing onto the 18.3.1main(Ken's #3418 migration) — parked infra. Gates still open: full build, design sign-off, and working review apps (review-app asset-prefix issue tracked separately).Stack (DX-1128)
@ably/uitokens + reset/core CSScn+heightsutilsIconcomponent@ably/uiTailwind scanmain)#3409–#3416 are a linear stack (each builds on the previous); #3417 is the combined view. ▶ = this PR.
Testing
🤖 Generated with Claude Code