Skip to content

DX-1128: docs — localise design system off @ably/ui (combined view for review/demo)#3417

Closed
jamiehenson wants to merge 8 commits into
mainfrom
dx-1128/docs-ably-ui-localisation
Closed

DX-1128: docs — localise design system off @ably/ui (combined view for review/demo)#3417
jamiehenson wants to merge 8 commits into
mainfrom
dx-1128/docs-ably-ui-localisation

Conversation

@jamiehenson

@jamiehenson jamiehenson commented Jun 17, 2026

Copy link
Copy Markdown
Member

Part of DX-1128. Combined view of the whole stack (#3409#3416) on top of main — for reviewing/demoing the localisation as one diff. Not for merge; the individual stacked PRs land it.

What it does

Removes @ably/ui as docs' design-system source: vendors the Tailwind theme + CSS, a local Icon, cn/heights, and the full visual component set (Badge/Button/LinkButton/FeaturedLink/Status, SegmentedControl/TabMenu, ProductTile, Code/CodeSnippet), plus the syntax-highlighter util. (~169 files.)

End state

Entire visual surface local; compiled global.css 6.7k lines. Remaining @ably/ui imports = insights (×6) + scripts (×2 — the SessionDataProvider/useSessionData context API); the old SessionData Redux store + Flash reducer are gone after rebasing onto the 18.3.1 main (Ken's #3418 migration) — parked infra. Gates still open: full build, design sign-off, and working review apps (review-app asset-prefix issue tracked separately).

Stack (DX-1128)

PR Role
#3409 Design foundation — vendor @ably/ui tokens + reset/core CSS
#3410 Local cn + heights utils
#3411 Docs-native Icon component
#3412 Presentational components (Badge, Button, LinkButton, FeaturedLink, Status)
#3413 Interactive components (SegmentedControl, TabMenu)
#3414 ProductTile + product data (leaf)
#3415 syntax-highlighter util + registry
#3416 Code + CodeSnippet — completes the lift; prunes dead CSS + drops @ably/ui Tailwind scan
#3417 Combined view of #3409#3416 — review/demo only (based on main)

#3409#3416 are a linear stack (each builds on the previous); #3417 is the combined view. ▶ = this PR.

Testing

  • Load the review app.
  • Check a sufficient sample of pages load with no visual regressions.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9dad9d15-64f4-4579-9f1a-a46cbc782087

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dx-1128/docs-ably-ui-localisation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jamiehenson jamiehenson added the review-app Create a Heroku review app label Jun 17, 2026
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--opzlvw June 17, 2026 13:33 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-ably-ui-localisation branch from 17d25cb to 2da466a Compare June 18, 2026 13:24
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--opzlvw June 18, 2026 13:24 Inactive
@jamiehenson jamiehenson marked this pull request as ready for review June 18, 2026 13:36
@jamiehenson jamiehenson marked this pull request as draft June 18, 2026 13:40
@jamiehenson jamiehenson force-pushed the dx-1128/docs-ably-ui-localisation branch from 2da466a to 6dff760 Compare June 18, 2026 14:34
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--opzlvw June 18, 2026 14:34 Inactive
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--twycxw June 18, 2026 14:54 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-ably-ui-localisation branch from 6dff760 to c1b3585 Compare June 18, 2026 14:57
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--twycxw June 18, 2026 14:57 Inactive
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--opzlvw June 18, 2026 14:57 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-ably-ui-localisation branch from c1b3585 to 0dd3b59 Compare June 18, 2026 15:50
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--twycxw June 18, 2026 15:50 Inactive
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--opzlvw June 18, 2026 15:50 Inactive
Vendor @ably/ui's Tailwind theme (inlined into tailwind.config.js) + reset/core/
component CSS under src/styles/ui/. Full CSS + the @ably/ui content glob retained
so each stacked PR stays self-sufficient; prune lands in the final PR.
@jamiehenson

Copy link
Copy Markdown
Member Author

Closing this combined-view branch — the individual stacked PRs (#3410#3416) are the source of truth for review and merge, and keeping a parallel squashed view in sync with the per-slice cascade isn't worth the upkeep.

~ 𝒞𝓁𝒶𝓊𝒹𝑒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-app Create a Heroku review app

Development

Successfully merging this pull request may close these issues.

2 participants