Skip to content

DX-1128: localise ProductTile + product data (leaf)#3414

Merged
jamiehenson merged 2 commits into
mainfrom
dx-1128/docs-producttile
Jun 26, 2026
Merged

DX-1128: localise ProductTile + product data (leaf)#3414
jamiehenson merged 2 commits into
mainfrom
dx-1128/docs-producttile

Conversation

@jamiehenson

@jamiehenson jamiehenson commented Jun 17, 2026

Copy link
Copy Markdown
Member

Part of DX-1128. Localises ProductTile + its product data (a leaf — copied per app).

What

src/components/ui/ProductTile.tsx + ProductTile/ (ProductIcon, ProductLabel, ProductDescription, data.ts). Product taxonomy data vendored locally. ProductIcon keeps rendering Ably's product glyphs through the local Icon — they're Ably-made glyphs, which is exactly what the glyphs-only Icon handles, so no icon-API change here.

Behaviour

No visual change intended. aiTransport copy kept at the docs-installed wording (adopting newer marketing copy is a separate call).

Stack (DX-1128)

PR Role
#3409 Design foundation — vendor @ably/ui tokens + reset/core CSS (merged)
#3410 Local cn + heights utils
#3411 Docs-native Icon component (Ably glyphs only; Heroicons imported directly)
#3412 Presentational components (Badge, Button, LinkButton, FeaturedLink, Status)
#3413 Interactive components (SegmentedControl, TabMenu)
#3414 ProductTile + product data (leaf)
#3415 syntax-highlighter util + registry
#3416 Code + CodeSnippet — completes the lift; prunes dead CSS + drops @ably/ui Tailwind scan

#3410#3416 are a linear stack, each building on the previous; #3409 has merged to main. ▶ = this PR.

Testing

  • Load the review app.
  • Check a sufficient sample of pages load with no visual regressions.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 203e4d68-ee5b-48e1-9ada-3635e06b1faa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dx-1128/docs-producttile

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from c57d361 to eb5a063 Compare June 18, 2026 13:18
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from 70e3af1 to 99f78c8 Compare June 18, 2026 13:19
@jamiehenson jamiehenson marked this pull request as ready for review June 18, 2026 13:36
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from eb5a063 to 6f2cac7 Compare June 18, 2026 14:34
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from 99f78c8 to d9a67e2 Compare June 18, 2026 14:34
@jamiehenson jamiehenson added the review-app Create a Heroku review app label Jun 18, 2026
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--kjeiib June 18, 2026 14:54 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from 6f2cac7 to e11ceaf Compare June 18, 2026 14:57
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from d9a67e2 to d53ff7f Compare June 18, 2026 14:57
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--kjeiib June 18, 2026 14:57 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from e11ceaf to f7308b7 Compare June 18, 2026 15:50
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from d53ff7f to 52b61ec Compare June 18, 2026 15:50
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--kjeiib June 18, 2026 15:50 Inactive
@jamiehenson jamiehenson marked this pull request as draft June 18, 2026 16:25
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from f7308b7 to b7b6074 Compare June 23, 2026 13:25
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from 52b61ec to 6f86900 Compare June 23, 2026 13:26
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--kjeiib June 23, 2026 13:26 Inactive
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--kjeiib June 23, 2026 14:11 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from 6f86900 to da88e2d Compare June 23, 2026 16:51
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--kjeiib June 23, 2026 16:51 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from 622c4dd to 8c73370 Compare June 23, 2026 17:15
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from a4b57d4 to ccb876a Compare June 24, 2026 08:38
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from 8c73370 to 486571c Compare June 24, 2026 08:38
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--kjeiib June 24, 2026 08:38 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from 486571c to 94e7bcb Compare June 25, 2026 07:33
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from ccb876a to 22beed9 Compare June 25, 2026 07:33
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--kjeiib June 25, 2026 07:34 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from 94e7bcb to bb75ac0 Compare June 25, 2026 13:54
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from 22beed9 to 534866c Compare June 25, 2026 13:54
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--kjeiib June 25, 2026 13:54 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from bb75ac0 to 0e10dee Compare June 25, 2026 14:22
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from 534866c to 3f5ca9d Compare June 25, 2026 14:22
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--kjeiib June 25, 2026 14:22 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from 3f5ca9d to f9dd330 Compare June 25, 2026 14:27
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--kjeiib June 25, 2026 14:27 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-components-interactive branch from 0e10dee to 72f8545 Compare June 25, 2026 14:38
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from f9dd330 to 573d680 Compare June 25, 2026 14:38
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--kjeiib June 25, 2026 14:39 Inactive
@jamiehenson

Copy link
Copy Markdown
Member Author

Where these are used (review aid):

  • ProductTilesrc/components/Homepage/PlatformAndProducts.tsx — the homepage product grid.
  • product data (ProductName / products) → src/components/Examples/{ExamplesFilter,ExamplesGrid,ExamplesContent}.tsx + src/data/content/types.ts.
  • The CTA rightIcon fix (string → <ArrowRightIcon />) is in ProductTile.tsx — the selected-tile "Explore" / "View docs" link.

~ 𝒞𝓁𝒶𝓊𝒹𝑒

Base automatically changed from dx-1128/docs-components-interactive to main June 26, 2026 08:10

@kennethkalmer kennethkalmer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against @ably/ui source and docs' installed build — faithful vendoring.

  • ProductTile/ProductIcon/ProductLabel/ProductDescription: formatting + import rewire only. rightIcon string → <ArrowRightIcon> from @heroicons/react/16/solid (= old -micro, 16px), sized by the size="xs" LinkButton slot (1rem). Dimension preserved.
  • ProductIcon still renders Ably product glyphs (icon-product-*) through the local Icon — all vendored.
  • data.ts: the only content delta vs upstream is aiTransport's description, and it matches docs' installed @ably/ui byte-for-byte ("Drop-in realtime continuity for Gen-2 AI experiences."). So no visual change; declining the newer upstream marketing copy is the right call, as the PR notes.
  • 5 caller import swaps (incl. ProductName in src/data/content/types.ts); no leftover @ably/ui/core/ProductTile imports.

Approving.

~ 𝒢𝓁𝒶𝓊𝒹𝑒

@jamiehenson jamiehenson enabled auto-merge June 26, 2026 14:16
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--kjeiib June 26, 2026 14:16 Inactive
@jamiehenson jamiehenson merged commit 50638fe into main Jun 26, 2026
7 checks passed
@jamiehenson jamiehenson deleted the dx-1128/docs-producttile branch June 26, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-app Create a Heroku review app

Development

Successfully merging this pull request may close these issues.

3 participants