Skip to content

DX-1128: localise syntax-highlighter util + registry#3415

Open
jamiehenson wants to merge 1 commit into
mainfrom
dx-1128/docs-syntax-highlighter
Open

DX-1128: localise syntax-highlighter util + registry#3415
jamiehenson wants to merge 1 commit into
mainfrom
dx-1128/docs-syntax-highlighter

Conversation

@jamiehenson

@jamiehenson jamiehenson commented Jun 17, 2026

Copy link
Copy Markdown
Member

Part of DX-1128. Localises the syntax-highlighter utility + language registry.

What

src/utilities/syntax-highlighter.js + syntax-highlighter-registry.js, vendored from @ably/ui. highlight.js (+ highlightjs-curl) promoted to direct deps (were transitive via @ably/ui). CodeBlock rewired to the local util. No icons involved.

Behaviour

No visual change intended.

Stack (DX-1128)

PR Role
#3409 Design foundation — vendor @ably/ui tokens + reset/core CSS (merged)
#3410 Local cn + heights utils
#3411 Docs-native Icon component (Ably glyphs only; Heroicons imported directly)
#3412 Presentational components (Badge, Button, LinkButton, FeaturedLink, Status)
#3413 Interactive components (SegmentedControl, TabMenu)
#3414 ProductTile + product data (leaf)
#3415 syntax-highlighter util + registry
#3416 Code + CodeSnippet — completes the lift; prunes dead CSS + drops @ably/ui Tailwind scan

#3410#3416 are a linear stack, each building on the previous; #3409 has merged to main. ▶ = this PR.

Testing

  • Load the review app.
  • Check a sufficient sample of pages load with no visual regressions.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6cb2d887-fbf4-490b-a8c4-7f71279a983e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dx-1128/docs-syntax-highlighter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from 70e3af1 to 99f78c8 Compare June 18, 2026 13:19
@jamiehenson jamiehenson force-pushed the dx-1128/docs-syntax-highlighter branch from f0aa029 to 712dec4 Compare June 18, 2026 13:19
@jamiehenson jamiehenson marked this pull request as ready for review June 18, 2026 13:36
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from 99f78c8 to d9a67e2 Compare June 18, 2026 14:34
@jamiehenson jamiehenson force-pushed the dx-1128/docs-syntax-highlighter branch from 712dec4 to 2218333 Compare June 18, 2026 14:34
@jamiehenson jamiehenson added the review-app Create a Heroku review app label Jun 18, 2026
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--yc0m43 June 18, 2026 14:54 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from d9a67e2 to d53ff7f Compare June 18, 2026 14:57
@jamiehenson jamiehenson force-pushed the dx-1128/docs-syntax-highlighter branch from 2218333 to 2f0072c Compare June 18, 2026 14:57
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--yc0m43 June 18, 2026 14:57 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from d53ff7f to 52b61ec Compare June 18, 2026 15:50
@jamiehenson jamiehenson force-pushed the dx-1128/docs-syntax-highlighter branch from 2f0072c to b67f0f1 Compare June 18, 2026 15:50
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--yc0m43 June 18, 2026 15:50 Inactive
@jamiehenson jamiehenson marked this pull request as draft June 18, 2026 16:25
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from 52b61ec to 6f86900 Compare June 23, 2026 13:26
@jamiehenson jamiehenson force-pushed the dx-1128/docs-syntax-highlighter branch from b67f0f1 to f97a86b Compare June 23, 2026 13:26
@ably-ci ably-ci temporarily deployed to ably-docs-dx-1128-docs--yc0m43 June 23, 2026 13:26 Inactive
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--yc0m43 June 23, 2026 14:11 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from 6f86900 to da88e2d Compare June 23, 2026 16:51
@jamiehenson jamiehenson force-pushed the dx-1128/docs-syntax-highlighter branch from f97a86b to adf4d03 Compare June 23, 2026 16:51
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--yc0m43 June 23, 2026 16:51 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-syntax-highlighter branch from adf4d03 to b7e67be Compare June 23, 2026 17:15
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from da88e2d to a4b57d4 Compare June 23, 2026 17:15
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--yc0m43 June 23, 2026 17:15 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from a4b57d4 to ccb876a Compare June 24, 2026 08:38
@jamiehenson jamiehenson force-pushed the dx-1128/docs-syntax-highlighter branch from b7e67be to 96e2ff3 Compare June 24, 2026 08:38
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--yc0m43 June 24, 2026 08:38 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-syntax-highlighter branch from 96e2ff3 to a1cbcb6 Compare June 25, 2026 07:33
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from ccb876a to 22beed9 Compare June 25, 2026 07:33
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--yc0m43 June 25, 2026 07:34 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-syntax-highlighter branch from a1cbcb6 to f2b8c6b Compare June 25, 2026 13:54
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch from 22beed9 to 534866c Compare June 25, 2026 13:54
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--yc0m43 June 25, 2026 13:54 Inactive
@jamiehenson jamiehenson force-pushed the dx-1128/docs-producttile branch 4 times, most recently from 573d680 to 5f29924 Compare June 25, 2026 14:39
@jamiehenson jamiehenson force-pushed the dx-1128/docs-syntax-highlighter branch from f2b8c6b to 040b28a Compare June 25, 2026 14:53
@jamiehenson jamiehenson temporarily deployed to ably-docs-dx-1128-docs--yc0m43 June 25, 2026 14:53 Inactive
@jamiehenson

Copy link
Copy Markdown
Member Author

Where this is used (review aid):

Note: the util + registry are now .ts (typed), not the vendored .jshighlightjs-curl (untyped) gets an ambient decl in src/globals.d.ts.

~ 𝒞𝓁𝒶𝓊𝒹𝑒

@jamiehenson jamiehenson marked this pull request as ready for review June 25, 2026 15:21
Base automatically changed from dx-1128/docs-producttile to main June 26, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-app Create a Heroku review app

Development

Successfully merging this pull request may close these issues.

2 participants